Do a cursory conversion of a few tests to GTest.
For now, this is the laziest conversion possible. The intent is to just
get the build setup ready so that we can get everything working in our
consumers. The intended end state is:
- The standalone build produces three test targets, one per library:
{crypto,ssl,decrepit}_tests.
- Each FOO_test is made up of:
FOO/**/*_test.cc
crypto/test/gtest_main.cc
test_support
- generate_build_files.py emits variables crypto_test_sources and
ssl_test_sources. These variables are populated with FindCFiles,
looking for *_test.cc.
- The consuming file assembles those variables into the two test targets
(plus decrepit) from there. This avoids having generate_build_files.py
emit actual build rules.
- Our standalone builders, Chromium, and Android just run the top-level
test targets using whatever GTest-based reporting story they have.
In transition, we start by converting one of two tests in each library
to populate the three test targets. Those are added to all_tests.json
and all_tests.go hacked to handle them transparently. This keeps our
standalone builder working.
generate_build_files.py, to start with, populates the new source lists
manually and subtracts them out of the old machinery. We emit both for
the time being. When this change rolls in, we'll write all the build
glue needed to build the GTest-based tests and add it to consumers'
continuous builders.
Next, we'll subsume a file-based test and get the consumers working with
that. (I.e. make sure the GTest targets can depend on a data file.)
Once that's all done, we'll be sure all this will work. At that point,
we start subsuming the remaining tests into the GTest targets and,
asynchronously, rewriting tests to use GTest properly rather than
cursory conversion here.
When all non-GTest tests are gone, the old generate_build_files.py hooks
will be removed, consumers updated to not depend on them, and standalone
builders converted to not rely on all_tests.go, which can then be
removed. (Unless bits end up being needed as a malloc test driver. I'm
thinking we'll want to do something with --gtest_filter.)
As part of this CL, I've bumped the CMake requirements (for
target_include_directories) and added a few suppressions for warnings
that GTest doesn't pass.
BUG=129
Change-Id: I881b26b07a8739cc0b52dbb51a30956908e1b71a
Reviewed-on: https://boringssl-review.googlesource.com/13232
Reviewed-by: Adam Langley <agl@google.com>
2017-01-20 00:05:47 +00:00
|
|
|
cmake_minimum_required (VERSION 2.8.11)
|
2014-06-20 20:00:00 +01:00
|
|
|
|
2017-12-04 22:19:49 +00:00
|
|
|
# Report AppleClang separately from Clang. Their version numbers are different.
|
|
|
|
# https://cmake.org/cmake/help/v3.0/policy/CMP0025.html
|
|
|
|
if(POLICY CMP0025)
|
|
|
|
cmake_policy(SET CMP0025 NEW)
|
|
|
|
endif()
|
|
|
|
|
2016-02-06 02:58:39 +00:00
|
|
|
# Defer enabling C and CXX languages.
|
|
|
|
project (BoringSSL NONE)
|
|
|
|
|
|
|
|
if(WIN32)
|
|
|
|
# On Windows, prefer cl over gcc if both are available. By default most of
|
|
|
|
# the CMake generators prefer gcc, even on Windows.
|
|
|
|
set(CMAKE_GENERATOR_CC cl)
|
|
|
|
endif()
|
|
|
|
|
2017-05-19 20:26:18 +01:00
|
|
|
include(sources.cmake)
|
|
|
|
|
2016-02-06 02:58:39 +00:00
|
|
|
enable_language(C)
|
|
|
|
enable_language(CXX)
|
2014-06-20 20:00:00 +01:00
|
|
|
|
2015-04-29 01:46:58 +01:00
|
|
|
if(ANDROID)
|
|
|
|
# Android-NDK CMake files reconfigure the path and so Go and Perl won't be
|
|
|
|
# found. However, ninja will still find them in $PATH if we just name them.
|
2016-05-19 14:28:14 +01:00
|
|
|
if(NOT PERL_EXECUTABLE)
|
|
|
|
set(PERL_EXECUTABLE "perl")
|
|
|
|
endif()
|
|
|
|
if(NOT GO_EXECUTABLE)
|
|
|
|
set(GO_EXECUTABLE "go")
|
|
|
|
endif()
|
2015-04-29 01:46:58 +01:00
|
|
|
else()
|
|
|
|
find_package(Perl REQUIRED)
|
|
|
|
find_program(GO_EXECUTABLE go)
|
|
|
|
endif()
|
2015-02-23 18:06:19 +00:00
|
|
|
|
2015-03-05 06:19:27 +00:00
|
|
|
if (NOT GO_EXECUTABLE)
|
|
|
|
message(FATAL_ERROR "Could not find Go")
|
|
|
|
endif()
|
|
|
|
|
2017-07-26 16:39:38 +01:00
|
|
|
if (BORINGSSL_ALLOW_CXX_RUNTIME)
|
|
|
|
add_definitions(-DBORINGSSL_ALLOW_CXX_RUNTIME)
|
|
|
|
endif()
|
|
|
|
|
2017-10-05 20:04:08 +01:00
|
|
|
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
|
|
|
|
set(CLANG 1)
|
|
|
|
endif()
|
|
|
|
|
|
|
|
if(CMAKE_COMPILER_IS_GNUCXX OR CLANG)
|
|
|
|
# Note clang-cl is odd and sets both CLANG and MSVC. We base our configuration
|
2018-01-05 20:43:09 +00:00
|
|
|
# primarily on our normal Clang one.
|
|
|
|
set(C_CXX_FLAGS "-Werror -Wformat=2 -Wsign-compare -Wmissing-field-initializers -Wwrite-strings")
|
2017-10-05 20:04:08 +01:00
|
|
|
if(MSVC)
|
2018-01-05 20:43:09 +00:00
|
|
|
# clang-cl sets different default warnings than clang. It also treats -Wall
|
|
|
|
# as -Weverything, to match MSVC. Instead -W3 is the alias for -Wall.
|
|
|
|
# See http://llvm.org/viewvc/llvm-project?view=revision&revision=319116
|
|
|
|
set(C_CXX_FLAGS "${C_CXX_FLAGS} -W3 -Wno-unused-parameter -fmsc-version=1900")
|
2017-10-05 20:04:08 +01:00
|
|
|
# googletest suppresses warning C4996 via a pragma, but clang-cl does not
|
|
|
|
# honor it. Suppress it here to compensate. See https://crbug.com/772117.
|
|
|
|
set(C_CXX_FLAGS "${C_CXX_FLAGS} -Wno-deprecated-declarations")
|
|
|
|
else()
|
2018-01-05 20:43:09 +00:00
|
|
|
set(C_CXX_FLAGS "${C_CXX_FLAGS} -Wall -ggdb -fvisibility=hidden -fno-common")
|
2017-10-05 20:04:08 +01:00
|
|
|
endif()
|
2017-09-20 16:51:54 +01:00
|
|
|
|
2017-10-05 20:04:08 +01:00
|
|
|
if(CLANG)
|
2017-07-31 19:03:38 +01:00
|
|
|
set(C_CXX_FLAGS "${C_CXX_FLAGS} -Wnewline-eof -fcolor-diagnostics")
|
2017-04-28 22:47:06 +01:00
|
|
|
else()
|
|
|
|
# GCC (at least 4.8.4) has a bug where it'll find unreachable free() calls
|
|
|
|
# and declare that the code is trying to free a stack pointer.
|
|
|
|
set(C_CXX_FLAGS "${C_CXX_FLAGS} -Wno-free-nonheap-object")
|
2016-08-29 19:59:31 +01:00
|
|
|
endif()
|
2017-09-20 16:51:54 +01:00
|
|
|
|
2017-10-05 20:04:08 +01:00
|
|
|
if(CLANG OR NOT "7.0.0" VERSION_GREATER CMAKE_C_COMPILER_VERSION)
|
2017-09-20 16:51:54 +01:00
|
|
|
set(C_CXX_FLAGS "${C_CXX_FLAGS} -Wimplicit-fallthrough")
|
|
|
|
endif()
|
|
|
|
|
2016-06-30 22:16:59 +01:00
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${C_CXX_FLAGS} -Wmissing-prototypes -Wold-style-definition -Wstrict-prototypes")
|
2017-10-05 20:04:08 +01:00
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${C_CXX_FLAGS} -Wmissing-declarations")
|
2017-07-26 16:39:38 +01:00
|
|
|
|
2017-10-05 20:04:08 +01:00
|
|
|
if(NOT MSVC)
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
|
2017-10-16 20:58:08 +01:00
|
|
|
if(APPLE)
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -stdlib=libc++")
|
|
|
|
endif()
|
2017-10-05 20:04:08 +01:00
|
|
|
if(NOT BORINGSSL_ALLOW_CXX_RUNTIME)
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-rtti")
|
|
|
|
endif()
|
2017-07-26 16:39:38 +01:00
|
|
|
endif()
|
|
|
|
|
2017-07-13 22:53:07 +01:00
|
|
|
# In GCC, -Wmissing-declarations is the C++ spelling of -Wmissing-prototypes
|
|
|
|
# and using the wrong one is an error. In Clang, -Wmissing-prototypes is the
|
|
|
|
# spelling for both and -Wmissing-declarations is some other warning.
|
|
|
|
#
|
|
|
|
# https://gcc.gnu.org/onlinedocs/gcc-7.1.0/gcc/Warning-Options.html#Warning-Options
|
|
|
|
# https://clang.llvm.org/docs/DiagnosticsReference.html#wmissing-prototypes
|
|
|
|
# https://clang.llvm.org/docs/DiagnosticsReference.html#wmissing-declarations
|
2017-10-05 20:04:08 +01:00
|
|
|
if(CLANG)
|
2017-09-20 16:51:54 +01:00
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wmissing-prototypes")
|
2017-07-13 22:53:07 +01:00
|
|
|
endif()
|
2017-10-09 20:09:43 +01:00
|
|
|
|
|
|
|
if(CMAKE_COMPILER_IS_GNUCXX AND "4.8" VERSION_GREATER CMAKE_C_COMPILER_VERSION)
|
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-array-bounds")
|
|
|
|
endif()
|
|
|
|
|
2014-06-20 20:00:00 +01:00
|
|
|
elseif(MSVC)
|
2015-01-29 00:20:02 +00:00
|
|
|
set(MSVC_DISABLED_WARNINGS_LIST
|
Do a cursory conversion of a few tests to GTest.
For now, this is the laziest conversion possible. The intent is to just
get the build setup ready so that we can get everything working in our
consumers. The intended end state is:
- The standalone build produces three test targets, one per library:
{crypto,ssl,decrepit}_tests.
- Each FOO_test is made up of:
FOO/**/*_test.cc
crypto/test/gtest_main.cc
test_support
- generate_build_files.py emits variables crypto_test_sources and
ssl_test_sources. These variables are populated with FindCFiles,
looking for *_test.cc.
- The consuming file assembles those variables into the two test targets
(plus decrepit) from there. This avoids having generate_build_files.py
emit actual build rules.
- Our standalone builders, Chromium, and Android just run the top-level
test targets using whatever GTest-based reporting story they have.
In transition, we start by converting one of two tests in each library
to populate the three test targets. Those are added to all_tests.json
and all_tests.go hacked to handle them transparently. This keeps our
standalone builder working.
generate_build_files.py, to start with, populates the new source lists
manually and subtracts them out of the old machinery. We emit both for
the time being. When this change rolls in, we'll write all the build
glue needed to build the GTest-based tests and add it to consumers'
continuous builders.
Next, we'll subsume a file-based test and get the consumers working with
that. (I.e. make sure the GTest targets can depend on a data file.)
Once that's all done, we'll be sure all this will work. At that point,
we start subsuming the remaining tests into the GTest targets and,
asynchronously, rewriting tests to use GTest properly rather than
cursory conversion here.
When all non-GTest tests are gone, the old generate_build_files.py hooks
will be removed, consumers updated to not depend on them, and standalone
builders converted to not rely on all_tests.go, which can then be
removed. (Unless bits end up being needed as a malloc test driver. I'm
thinking we'll want to do something with --gtest_filter.)
As part of this CL, I've bumped the CMake requirements (for
target_include_directories) and added a few suppressions for warnings
that GTest doesn't pass.
BUG=129
Change-Id: I881b26b07a8739cc0b52dbb51a30956908e1b71a
Reviewed-on: https://boringssl-review.googlesource.com/13232
Reviewed-by: Adam Langley <agl@google.com>
2017-01-20 00:05:47 +00:00
|
|
|
"C4061" # enumerator 'identifier' in switch of enum 'enumeration' is not
|
|
|
|
# explicitly handled by a case label
|
|
|
|
# Disable this because it flags even when there is a default.
|
2015-01-29 00:20:02 +00:00
|
|
|
"C4100" # 'exarg' : unreferenced formal parameter
|
|
|
|
"C4127" # conditional expression is constant
|
|
|
|
"C4200" # nonstandard extension used : zero-sized array in
|
|
|
|
# struct/union.
|
2016-11-13 01:32:10 +00:00
|
|
|
"C4204" # nonstandard extension used: non-constant aggregate initializer
|
|
|
|
"C4221" # nonstandard extension used : 'identifier' : cannot be
|
|
|
|
# initialized using address of automatic variable
|
2015-01-29 00:20:02 +00:00
|
|
|
"C4242" # 'function' : conversion from 'int' to 'uint8_t',
|
|
|
|
# possible loss of data
|
|
|
|
"C4244" # 'function' : conversion from 'int' to 'uint8_t',
|
|
|
|
# possible loss of data
|
2015-02-11 20:12:05 +00:00
|
|
|
"C4267" # conversion from 'size_t' to 'int', possible loss of data
|
|
|
|
"C4371" # layout of class may have changed from a previous version of the
|
|
|
|
# compiler due to better packing of member '...'
|
|
|
|
"C4388" # signed/unsigned mismatch
|
2015-01-29 00:20:02 +00:00
|
|
|
"C4296" # '>=' : expression is always true
|
|
|
|
"C4350" # behavior change: 'std::_Wrap_alloc...'
|
|
|
|
"C4365" # '=' : conversion from 'size_t' to 'int',
|
|
|
|
# signed/unsigned mismatch
|
|
|
|
"C4389" # '!=' : signed/unsigned mismatch
|
2016-05-02 17:57:01 +01:00
|
|
|
"C4464" # relative include path contains '..'
|
2015-01-29 00:20:02 +00:00
|
|
|
"C4510" # 'argument' : default constructor could not be generated
|
|
|
|
"C4512" # 'argument' : assignment operator could not be generated
|
|
|
|
"C4514" # 'function': unreferenced inline function has been removed
|
|
|
|
"C4548" # expression before comma has no effect; expected expression with
|
|
|
|
# side-effect" caused by FD_* macros.
|
|
|
|
"C4610" # struct 'argument' can never be instantiated - user defined
|
|
|
|
# constructor required.
|
2016-05-02 17:57:01 +01:00
|
|
|
"C4623" # default constructor was implicitly defined as deleted
|
2015-02-11 20:12:05 +00:00
|
|
|
"C4625" # copy constructor could not be generated because a base class
|
|
|
|
# copy constructor is inaccessible or deleted
|
|
|
|
"C4626" # assignment operator could not be generated because a base class
|
|
|
|
# assignment operator is inaccessible or deleted
|
Do a cursory conversion of a few tests to GTest.
For now, this is the laziest conversion possible. The intent is to just
get the build setup ready so that we can get everything working in our
consumers. The intended end state is:
- The standalone build produces three test targets, one per library:
{crypto,ssl,decrepit}_tests.
- Each FOO_test is made up of:
FOO/**/*_test.cc
crypto/test/gtest_main.cc
test_support
- generate_build_files.py emits variables crypto_test_sources and
ssl_test_sources. These variables are populated with FindCFiles,
looking for *_test.cc.
- The consuming file assembles those variables into the two test targets
(plus decrepit) from there. This avoids having generate_build_files.py
emit actual build rules.
- Our standalone builders, Chromium, and Android just run the top-level
test targets using whatever GTest-based reporting story they have.
In transition, we start by converting one of two tests in each library
to populate the three test targets. Those are added to all_tests.json
and all_tests.go hacked to handle them transparently. This keeps our
standalone builder working.
generate_build_files.py, to start with, populates the new source lists
manually and subtracts them out of the old machinery. We emit both for
the time being. When this change rolls in, we'll write all the build
glue needed to build the GTest-based tests and add it to consumers'
continuous builders.
Next, we'll subsume a file-based test and get the consumers working with
that. (I.e. make sure the GTest targets can depend on a data file.)
Once that's all done, we'll be sure all this will work. At that point,
we start subsuming the remaining tests into the GTest targets and,
asynchronously, rewriting tests to use GTest properly rather than
cursory conversion here.
When all non-GTest tests are gone, the old generate_build_files.py hooks
will be removed, consumers updated to not depend on them, and standalone
builders converted to not rely on all_tests.go, which can then be
removed. (Unless bits end up being needed as a malloc test driver. I'm
thinking we'll want to do something with --gtest_filter.)
As part of this CL, I've bumped the CMake requirements (for
target_include_directories) and added a few suppressions for warnings
that GTest doesn't pass.
BUG=129
Change-Id: I881b26b07a8739cc0b52dbb51a30956908e1b71a
Reviewed-on: https://boringssl-review.googlesource.com/13232
Reviewed-by: Adam Langley <agl@google.com>
2017-01-20 00:05:47 +00:00
|
|
|
"C4668" # 'symbol' is not defined as a preprocessor macro, replacing with
|
|
|
|
# '0' for 'directives'
|
|
|
|
# Disable this because GTest uses it everywhere.
|
2015-01-29 00:20:02 +00:00
|
|
|
"C4706" # assignment within conditional expression
|
|
|
|
"C4710" # 'function': function not inlined
|
|
|
|
"C4711" # function 'function' selected for inline expansion
|
|
|
|
"C4800" # 'int' : forcing value to bool 'true' or 'false'
|
|
|
|
# (performance warning)
|
|
|
|
"C4820" # 'bytes' bytes padding added after construct 'member_name'
|
Do a cursory conversion of a few tests to GTest.
For now, this is the laziest conversion possible. The intent is to just
get the build setup ready so that we can get everything working in our
consumers. The intended end state is:
- The standalone build produces three test targets, one per library:
{crypto,ssl,decrepit}_tests.
- Each FOO_test is made up of:
FOO/**/*_test.cc
crypto/test/gtest_main.cc
test_support
- generate_build_files.py emits variables crypto_test_sources and
ssl_test_sources. These variables are populated with FindCFiles,
looking for *_test.cc.
- The consuming file assembles those variables into the two test targets
(plus decrepit) from there. This avoids having generate_build_files.py
emit actual build rules.
- Our standalone builders, Chromium, and Android just run the top-level
test targets using whatever GTest-based reporting story they have.
In transition, we start by converting one of two tests in each library
to populate the three test targets. Those are added to all_tests.json
and all_tests.go hacked to handle them transparently. This keeps our
standalone builder working.
generate_build_files.py, to start with, populates the new source lists
manually and subtracts them out of the old machinery. We emit both for
the time being. When this change rolls in, we'll write all the build
glue needed to build the GTest-based tests and add it to consumers'
continuous builders.
Next, we'll subsume a file-based test and get the consumers working with
that. (I.e. make sure the GTest targets can depend on a data file.)
Once that's all done, we'll be sure all this will work. At that point,
we start subsuming the remaining tests into the GTest targets and,
asynchronously, rewriting tests to use GTest properly rather than
cursory conversion here.
When all non-GTest tests are gone, the old generate_build_files.py hooks
will be removed, consumers updated to not depend on them, and standalone
builders converted to not rely on all_tests.go, which can then be
removed. (Unless bits end up being needed as a malloc test driver. I'm
thinking we'll want to do something with --gtest_filter.)
As part of this CL, I've bumped the CMake requirements (for
target_include_directories) and added a few suppressions for warnings
that GTest doesn't pass.
BUG=129
Change-Id: I881b26b07a8739cc0b52dbb51a30956908e1b71a
Reviewed-on: https://boringssl-review.googlesource.com/13232
Reviewed-by: Adam Langley <agl@google.com>
2017-01-20 00:05:47 +00:00
|
|
|
"C5026" # move constructor was implicitly defined as deleted
|
2016-05-02 17:57:01 +01:00
|
|
|
"C5027" # move assignment operator was implicitly defined as deleted
|
|
|
|
)
|
|
|
|
set(MSVC_LEVEL4_WARNINGS_LIST
|
|
|
|
# See https://connect.microsoft.com/VisualStudio/feedback/details/1217660/warning-c4265-when-using-functional-header
|
|
|
|
"C4265" # class has virtual functions, but destructor is not virtual
|
|
|
|
)
|
2015-01-29 00:20:02 +00:00
|
|
|
string(REPLACE "C" " -wd" MSVC_DISABLED_WARNINGS_STR
|
|
|
|
${MSVC_DISABLED_WARNINGS_LIST})
|
2016-05-02 17:57:01 +01:00
|
|
|
string(REPLACE "C" " -w4" MSVC_LEVEL4_WARNINGS_STR
|
|
|
|
${MSVC_LEVEL4_WARNINGS_LIST})
|
2018-03-11 10:20:51 +00:00
|
|
|
set(CMAKE_C_FLAGS "-utf-8 -Wall -WX ${MSVC_DISABLED_WARNINGS_STR} ${MSVC_LEVEL4_WARNINGS_STR}")
|
|
|
|
set(CMAKE_CXX_FLAGS "-utf-8 -Wall -WX ${MSVC_DISABLED_WARNINGS_STR} ${MSVC_LEVEL4_WARNINGS_STR}")
|
2017-08-16 20:25:27 +01:00
|
|
|
endif()
|
|
|
|
|
|
|
|
if(WIN32)
|
2015-01-29 00:37:10 +00:00
|
|
|
add_definitions(-D_HAS_EXCEPTIONS=0)
|
2015-01-29 04:34:47 +00:00
|
|
|
add_definitions(-DWIN32_LEAN_AND_MEAN)
|
2015-04-02 18:20:01 +01:00
|
|
|
add_definitions(-DNOMINMAX)
|
2017-06-16 01:44:30 +01:00
|
|
|
# Allow use of fopen.
|
|
|
|
add_definitions(-D_CRT_SECURE_NO_WARNINGS)
|
|
|
|
# VS 2017 and higher supports STL-only warning suppressions.
|
|
|
|
add_definitions("-D_STL_EXTRA_DISABLED_WARNINGS=4774 4987")
|
2014-06-20 20:00:00 +01:00
|
|
|
endif()
|
|
|
|
|
2015-02-28 05:00:44 +00:00
|
|
|
if((CMAKE_COMPILER_IS_GNUCXX AND CMAKE_C_COMPILER_VERSION VERSION_GREATER "4.7.99") OR
|
2017-10-05 20:04:08 +01:00
|
|
|
CLANG)
|
2015-01-29 00:37:10 +00:00
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wshadow")
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wshadow")
|
2015-01-16 23:20:54 +00:00
|
|
|
endif()
|
|
|
|
|
2016-06-09 21:22:26 +01:00
|
|
|
if(CMAKE_COMPILER_IS_GNUCXX)
|
2017-10-05 20:04:08 +01:00
|
|
|
if ((CMAKE_C_COMPILER_VERSION VERSION_GREATER "4.8.99") OR CLANG)
|
2016-06-09 21:22:26 +01:00
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=c11")
|
|
|
|
else()
|
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=c99")
|
|
|
|
endif()
|
|
|
|
endif()
|
|
|
|
|
|
|
|
# pthread_rwlock_t requires a feature flag.
|
|
|
|
if(NOT WIN32)
|
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -D_XOPEN_SOURCE=700")
|
2015-05-15 20:01:29 +01:00
|
|
|
endif()
|
|
|
|
|
2015-11-09 21:57:26 +00:00
|
|
|
if(FUZZ)
|
2017-10-05 20:04:08 +01:00
|
|
|
if(NOT CLANG)
|
2016-09-28 22:14:01 +01:00
|
|
|
message(FATAL_ERROR "You need to build with Clang for fuzzing to work")
|
2015-11-09 21:57:26 +00:00
|
|
|
endif()
|
|
|
|
|
2016-11-04 22:59:33 +00:00
|
|
|
add_definitions(-DBORINGSSL_UNSAFE_DETERMINISTIC_MODE)
|
|
|
|
set(RUNNER_ARGS "-deterministic")
|
|
|
|
|
|
|
|
if(NOT NO_FUZZER_MODE)
|
|
|
|
add_definitions(-DBORINGSSL_UNSAFE_FUZZER_MODE)
|
|
|
|
set(RUNNER_ARGS ${RUNNER_ARGS} "-fuzzer" "-shim-config" "fuzzer_mode.json")
|
|
|
|
endif()
|
2016-03-02 03:57:32 +00:00
|
|
|
|
2017-05-10 17:02:58 +01:00
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address -fsanitize-coverage=edge,indirect-calls,trace-pc-guard")
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -fsanitize-coverage=edge,indirect-calls,trace-pc-guard")
|
2015-11-09 21:57:26 +00:00
|
|
|
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address")
|
2015-11-10 23:00:51 +00:00
|
|
|
link_directories(.)
|
2015-11-09 21:57:26 +00:00
|
|
|
endif()
|
|
|
|
|
2014-07-31 00:02:14 +01:00
|
|
|
add_definitions(-DBORINGSSL_IMPLEMENTATION)
|
|
|
|
|
2015-01-28 05:50:21 +00:00
|
|
|
if (BUILD_SHARED_LIBS)
|
2015-01-29 00:37:10 +00:00
|
|
|
add_definitions(-DBORINGSSL_SHARED_LIBRARY)
|
|
|
|
# Enable position-independent code globally. This is needed because
|
|
|
|
# some library targets are OBJECT libraries.
|
|
|
|
set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)
|
2015-01-28 05:50:21 +00:00
|
|
|
endif()
|
|
|
|
|
2017-04-07 04:26:04 +01:00
|
|
|
if (MSAN)
|
2017-10-05 20:04:08 +01:00
|
|
|
if(NOT CLANG)
|
2017-04-07 04:26:04 +01:00
|
|
|
message(FATAL_ERROR "Cannot enable MSAN unless using Clang")
|
|
|
|
endif()
|
|
|
|
|
|
|
|
if (ASAN)
|
|
|
|
message(FATAL_ERROR "ASAN and MSAN are mutually exclusive")
|
|
|
|
endif()
|
|
|
|
|
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=memory -fsanitize-memory-track-origins -fno-omit-frame-pointer")
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=memory -fsanitize-memory-track-origins -fno-omit-frame-pointer")
|
|
|
|
set(OPENSSL_NO_ASM "1")
|
|
|
|
endif()
|
|
|
|
|
|
|
|
if (ASAN)
|
2017-10-05 20:04:08 +01:00
|
|
|
if(NOT CLANG)
|
2017-04-07 04:26:04 +01:00
|
|
|
message(FATAL_ERROR "Cannot enable ASAN unless using Clang")
|
|
|
|
endif()
|
|
|
|
|
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=address -fsanitize-address-use-after-scope -fno-omit-frame-pointer")
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -fsanitize-address-use-after-scope -fno-omit-frame-pointer")
|
|
|
|
set(OPENSSL_NO_ASM "1")
|
|
|
|
endif()
|
|
|
|
|
2017-11-21 13:16:42 +00:00
|
|
|
if(CFI)
|
|
|
|
if(NOT CLANG)
|
|
|
|
message(FATAL_ERROR "Cannot enable CFI unless using Clang")
|
|
|
|
endif()
|
|
|
|
|
|
|
|
# TODO(crbug.com/785442): Remove -fsanitize-cfi-icall-generalize-pointers.
|
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=cfi -fno-sanitize-trap=cfi -fsanitize-cfi-icall-generalize-pointers -flto")
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=cfi -fno-sanitize-trap=cfi -fsanitize-cfi-icall-generalize-pointers -flto")
|
|
|
|
# We use Chromium's copy of clang, which requires -fuse-ld=lld if building
|
|
|
|
# with -flto. That, in turn, can't handle -ggdb.
|
|
|
|
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=lld")
|
|
|
|
string(REPLACE "-ggdb" "-g" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
|
|
|
|
string(REPLACE "-ggdb" "-g" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
|
|
|
|
# -flto causes object files to contain LLVM bitcode. Mixing those with
|
|
|
|
# assembly output in the same static library breaks the linker.
|
|
|
|
set(OPENSSL_NO_ASM "1")
|
|
|
|
endif()
|
|
|
|
|
2017-04-07 04:26:04 +01:00
|
|
|
if (GCOV)
|
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fprofile-arcs -ftest-coverage")
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fprofile-arcs -ftest-coverage")
|
|
|
|
endif()
|
|
|
|
|
|
|
|
if(FIPS)
|
|
|
|
add_definitions(-DBORINGSSL_FIPS)
|
2017-05-17 21:05:50 +01:00
|
|
|
if(FIPS_BREAK_TEST)
|
|
|
|
add_definitions("-DBORINGSSL_FIPS_BREAK_${FIPS_BREAK_TEST}=1")
|
|
|
|
endif()
|
|
|
|
# Delocate does not work for ASan and MSan builds.
|
|
|
|
if(NOT ASAN AND NOT MSAN)
|
|
|
|
set(FIPS_DELOCATE "1")
|
|
|
|
endif()
|
2017-04-07 04:26:04 +01:00
|
|
|
endif()
|
|
|
|
|
|
|
|
# CMake's iOS support uses Apple's multiple-architecture toolchain. It takes an
|
|
|
|
# architecture list from CMAKE_OSX_ARCHITECTURES, leaves CMAKE_SYSTEM_PROCESSOR
|
|
|
|
# alone, and expects all architecture-specific logic to be conditioned within
|
|
|
|
# the source files rather than the build. This does not work for our assembly
|
|
|
|
# files, so we fix CMAKE_SYSTEM_PROCESSOR and only support single-architecture
|
|
|
|
# builds.
|
|
|
|
if (NOT OPENSSL_NO_ASM AND CMAKE_OSX_ARCHITECTURES)
|
|
|
|
list(LENGTH CMAKE_OSX_ARCHITECTURES NUM_ARCHES)
|
|
|
|
if (NOT ${NUM_ARCHES} EQUAL 1)
|
|
|
|
message(FATAL_ERROR "Universal binaries not supported.")
|
|
|
|
endif()
|
|
|
|
list(GET CMAKE_OSX_ARCHITECTURES 0 CMAKE_SYSTEM_PROCESSOR)
|
|
|
|
endif()
|
|
|
|
|
|
|
|
if (OPENSSL_NO_ASM)
|
|
|
|
add_definitions(-DOPENSSL_NO_ASM)
|
|
|
|
set(ARCH "generic")
|
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "x86_64")
|
2015-01-29 00:37:10 +00:00
|
|
|
set(ARCH "x86_64")
|
2014-07-31 11:09:49 +01:00
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "amd64")
|
2015-01-29 00:37:10 +00:00
|
|
|
set(ARCH "x86_64")
|
2014-06-20 20:00:00 +01:00
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "AMD64")
|
2015-01-29 00:37:10 +00:00
|
|
|
# cmake reports AMD64 on Windows, but we might be building for 32-bit.
|
|
|
|
if (CMAKE_CL_64)
|
|
|
|
set(ARCH "x86_64")
|
|
|
|
else()
|
|
|
|
set(ARCH "x86")
|
|
|
|
endif()
|
2014-06-20 20:00:00 +01:00
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "x86")
|
2015-01-29 00:37:10 +00:00
|
|
|
set(ARCH "x86")
|
2014-07-31 11:09:49 +01:00
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "i386")
|
2015-01-29 00:37:10 +00:00
|
|
|
set(ARCH "x86")
|
2014-08-11 21:27:44 +01:00
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "i686")
|
2015-01-29 00:37:10 +00:00
|
|
|
set(ARCH "x86")
|
2015-01-09 23:44:37 +00:00
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "aarch64")
|
2015-01-29 00:37:10 +00:00
|
|
|
set(ARCH "aarch64")
|
2017-04-07 04:26:04 +01:00
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "arm64")
|
|
|
|
set(ARCH "aarch64")
|
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} MATCHES "^arm*")
|
|
|
|
set(ARCH "arm")
|
2016-10-28 14:05:32 +01:00
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "mips")
|
|
|
|
# Just to avoid the “unknown processor” error.
|
2017-01-24 22:18:09 +00:00
|
|
|
set(ARCH "generic")
|
2016-11-12 01:18:53 +00:00
|
|
|
elseif (${CMAKE_SYSTEM_PROCESSOR} STREQUAL "ppc64le")
|
|
|
|
set(ARCH "ppc64le")
|
2014-06-20 20:00:00 +01:00
|
|
|
else()
|
2015-01-29 00:37:10 +00:00
|
|
|
message(FATAL_ERROR "Unknown processor:" ${CMAKE_SYSTEM_PROCESSOR})
|
2014-06-20 20:00:00 +01:00
|
|
|
endif()
|
|
|
|
|
2017-12-13 23:08:47 +00:00
|
|
|
if (ANDROID AND NOT ANDROID_NDK_REVISION AND ${ARCH} STREQUAL "arm")
|
|
|
|
# The third-party Android-NDK CMake files somehow fail to set the -march flag
|
|
|
|
# for assembly files. Without this flag, the compiler believes that it's
|
2015-04-29 01:46:58 +01:00
|
|
|
# building for ARMv5.
|
2017-12-13 23:08:47 +00:00
|
|
|
set(CMAKE_ASM_FLAGS "-march=${CMAKE_SYSTEM_PROCESSOR} ${CMAKE_ASM_FLAGS}")
|
2015-04-29 01:46:58 +01:00
|
|
|
endif()
|
|
|
|
|
2017-10-27 15:43:15 +01:00
|
|
|
if (${ARCH} STREQUAL "x86" AND APPLE AND ${CMAKE_VERSION} VERSION_LESS "3.0")
|
2015-01-29 00:37:10 +00:00
|
|
|
# With CMake 2.8.x, ${CMAKE_SYSTEM_PROCESSOR} evalutes to i386 on OS X,
|
|
|
|
# but clang defaults to 64-bit builds on OS X unless otherwise told.
|
|
|
|
# Set ARCH to x86_64 so clang and CMake agree. This is fixed in CMake 3.
|
|
|
|
set(ARCH "x86_64")
|
2014-11-18 20:14:46 +00:00
|
|
|
endif()
|
|
|
|
|
Do a cursory conversion of a few tests to GTest.
For now, this is the laziest conversion possible. The intent is to just
get the build setup ready so that we can get everything working in our
consumers. The intended end state is:
- The standalone build produces three test targets, one per library:
{crypto,ssl,decrepit}_tests.
- Each FOO_test is made up of:
FOO/**/*_test.cc
crypto/test/gtest_main.cc
test_support
- generate_build_files.py emits variables crypto_test_sources and
ssl_test_sources. These variables are populated with FindCFiles,
looking for *_test.cc.
- The consuming file assembles those variables into the two test targets
(plus decrepit) from there. This avoids having generate_build_files.py
emit actual build rules.
- Our standalone builders, Chromium, and Android just run the top-level
test targets using whatever GTest-based reporting story they have.
In transition, we start by converting one of two tests in each library
to populate the three test targets. Those are added to all_tests.json
and all_tests.go hacked to handle them transparently. This keeps our
standalone builder working.
generate_build_files.py, to start with, populates the new source lists
manually and subtracts them out of the old machinery. We emit both for
the time being. When this change rolls in, we'll write all the build
glue needed to build the GTest-based tests and add it to consumers'
continuous builders.
Next, we'll subsume a file-based test and get the consumers working with
that. (I.e. make sure the GTest targets can depend on a data file.)
Once that's all done, we'll be sure all this will work. At that point,
we start subsuming the remaining tests into the GTest targets and,
asynchronously, rewriting tests to use GTest properly rather than
cursory conversion here.
When all non-GTest tests are gone, the old generate_build_files.py hooks
will be removed, consumers updated to not depend on them, and standalone
builders converted to not rely on all_tests.go, which can then be
removed. (Unless bits end up being needed as a malloc test driver. I'm
thinking we'll want to do something with --gtest_filter.)
As part of this CL, I've bumped the CMake requirements (for
target_include_directories) and added a few suppressions for warnings
that GTest doesn't pass.
BUG=129
Change-Id: I881b26b07a8739cc0b52dbb51a30956908e1b71a
Reviewed-on: https://boringssl-review.googlesource.com/13232
Reviewed-by: Adam Langley <agl@google.com>
2017-01-20 00:05:47 +00:00
|
|
|
# Add minimal googletest targets. The provided one has many side-effects, and
|
|
|
|
# googletest has a very straightforward build.
|
2018-01-04 07:07:58 +00:00
|
|
|
add_library(boringssl_gtest third_party/googletest/src/gtest-all.cc)
|
|
|
|
target_include_directories(boringssl_gtest PRIVATE third_party/googletest)
|
Do a cursory conversion of a few tests to GTest.
For now, this is the laziest conversion possible. The intent is to just
get the build setup ready so that we can get everything working in our
consumers. The intended end state is:
- The standalone build produces three test targets, one per library:
{crypto,ssl,decrepit}_tests.
- Each FOO_test is made up of:
FOO/**/*_test.cc
crypto/test/gtest_main.cc
test_support
- generate_build_files.py emits variables crypto_test_sources and
ssl_test_sources. These variables are populated with FindCFiles,
looking for *_test.cc.
- The consuming file assembles those variables into the two test targets
(plus decrepit) from there. This avoids having generate_build_files.py
emit actual build rules.
- Our standalone builders, Chromium, and Android just run the top-level
test targets using whatever GTest-based reporting story they have.
In transition, we start by converting one of two tests in each library
to populate the three test targets. Those are added to all_tests.json
and all_tests.go hacked to handle them transparently. This keeps our
standalone builder working.
generate_build_files.py, to start with, populates the new source lists
manually and subtracts them out of the old machinery. We emit both for
the time being. When this change rolls in, we'll write all the build
glue needed to build the GTest-based tests and add it to consumers'
continuous builders.
Next, we'll subsume a file-based test and get the consumers working with
that. (I.e. make sure the GTest targets can depend on a data file.)
Once that's all done, we'll be sure all this will work. At that point,
we start subsuming the remaining tests into the GTest targets and,
asynchronously, rewriting tests to use GTest properly rather than
cursory conversion here.
When all non-GTest tests are gone, the old generate_build_files.py hooks
will be removed, consumers updated to not depend on them, and standalone
builders converted to not rely on all_tests.go, which can then be
removed. (Unless bits end up being needed as a malloc test driver. I'm
thinking we'll want to do something with --gtest_filter.)
As part of this CL, I've bumped the CMake requirements (for
target_include_directories) and added a few suppressions for warnings
that GTest doesn't pass.
BUG=129
Change-Id: I881b26b07a8739cc0b52dbb51a30956908e1b71a
Reviewed-on: https://boringssl-review.googlesource.com/13232
Reviewed-by: Adam Langley <agl@google.com>
2017-01-20 00:05:47 +00:00
|
|
|
|
|
|
|
include_directories(third_party/googletest/include)
|
|
|
|
|
Add a run_tests target to run all tests.
It's very annoying having to remember the right incant every time I want
to switch around between my build, build-release, build-asan, etc.,
output directories.
Unfortunately, this target is pretty unfriendly without CMake 3.2+ (and
Ninja 1.5+). This combination gives a USES_TERMINAL flag to
add_custom_target which uses Ninja's "console" pool, otherwise the
output buffering gets in the way. Ubuntu LTS is still on an older CMake,
so do a version check in the meantime.
CMake also has its own test mechanism (CTest), but this doesn't use it.
It seems to prefer knowing what all the tests are and then tries to do
its own output management and parallelizing and such. We already have
our own runners. all_tests.go could actually be converted tidily, but
generate_build_files.py also needs to read it, and runner.go has very
specific needs.
Naming the target ninja -C build test would be nice, but CTest squats
that name and CMake grumps when you use a reserved name, so I've gone
with run_tests.
Change-Id: Ibd20ebd50febe1b4e91bb19921f3bbbd9fbcf66c
Reviewed-on: https://boringssl-review.googlesource.com/6270
Reviewed-by: Adam Langley <alangley@gmail.com>
2015-10-15 02:34:40 +01:00
|
|
|
# Declare a dummy target to build all unit tests. Test targets should inject
|
|
|
|
# themselves as dependencies next to the target definition.
|
|
|
|
add_custom_target(all_tests)
|
|
|
|
|
2017-05-19 20:26:18 +01:00
|
|
|
add_custom_command(
|
|
|
|
OUTPUT crypto_test_data.cc
|
|
|
|
COMMAND ${GO_EXECUTABLE} run util/embed_test_data.go ${CRYPTO_TEST_DATA} >
|
|
|
|
${CMAKE_CURRENT_BINARY_DIR}/crypto_test_data.cc
|
|
|
|
DEPENDS util/embed_test_data.go ${CRYPTO_TEST_DATA}
|
|
|
|
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR})
|
|
|
|
|
|
|
|
add_library(crypto_test_data OBJECT crypto_test_data.cc)
|
|
|
|
|
2014-06-20 20:00:00 +01:00
|
|
|
add_subdirectory(crypto)
|
2017-10-30 15:58:33 +00:00
|
|
|
add_subdirectory(third_party/fiat)
|
2014-06-20 20:00:00 +01:00
|
|
|
add_subdirectory(ssl)
|
|
|
|
add_subdirectory(ssl/test)
|
2017-05-12 23:34:45 +01:00
|
|
|
add_subdirectory(fipstools)
|
2014-06-20 20:00:00 +01:00
|
|
|
add_subdirectory(tool)
|
2015-02-03 18:45:12 +00:00
|
|
|
add_subdirectory(decrepit)
|
Add a run_tests target to run all tests.
It's very annoying having to remember the right incant every time I want
to switch around between my build, build-release, build-asan, etc.,
output directories.
Unfortunately, this target is pretty unfriendly without CMake 3.2+ (and
Ninja 1.5+). This combination gives a USES_TERMINAL flag to
add_custom_target which uses Ninja's "console" pool, otherwise the
output buffering gets in the way. Ubuntu LTS is still on an older CMake,
so do a version check in the meantime.
CMake also has its own test mechanism (CTest), but this doesn't use it.
It seems to prefer knowing what all the tests are and then tries to do
its own output management and parallelizing and such. We already have
our own runners. all_tests.go could actually be converted tidily, but
generate_build_files.py also needs to read it, and runner.go has very
specific needs.
Naming the target ninja -C build test would be nice, but CTest squats
that name and CMake grumps when you use a reserved name, so I've gone
with run_tests.
Change-Id: Ibd20ebd50febe1b4e91bb19921f3bbbd9fbcf66c
Reviewed-on: https://boringssl-review.googlesource.com/6270
Reviewed-by: Adam Langley <alangley@gmail.com>
2015-10-15 02:34:40 +01:00
|
|
|
|
2015-11-09 21:57:26 +00:00
|
|
|
if(FUZZ)
|
2017-05-10 21:07:56 +01:00
|
|
|
if(LIBFUZZER_FROM_DEPS)
|
|
|
|
file(GLOB LIBFUZZER_SOURCES "util/bot/libFuzzer/*.cpp")
|
|
|
|
add_library(Fuzzer STATIC ${LIBFUZZER_SOURCES})
|
|
|
|
# libFuzzer does not pass our aggressive warnings. It also must be built
|
|
|
|
# without -fsanitize-coverage options or clang crashes.
|
2017-07-14 16:02:39 +01:00
|
|
|
set_target_properties(Fuzzer PROPERTIES COMPILE_FLAGS "-Wno-shadow -Wno-format-nonliteral -Wno-missing-prototypes -fsanitize-coverage=0")
|
2017-05-10 21:07:56 +01:00
|
|
|
endif()
|
|
|
|
|
2015-11-09 21:57:26 +00:00
|
|
|
add_subdirectory(fuzz)
|
|
|
|
endif()
|
|
|
|
|
Add a run_tests target to run all tests.
It's very annoying having to remember the right incant every time I want
to switch around between my build, build-release, build-asan, etc.,
output directories.
Unfortunately, this target is pretty unfriendly without CMake 3.2+ (and
Ninja 1.5+). This combination gives a USES_TERMINAL flag to
add_custom_target which uses Ninja's "console" pool, otherwise the
output buffering gets in the way. Ubuntu LTS is still on an older CMake,
so do a version check in the meantime.
CMake also has its own test mechanism (CTest), but this doesn't use it.
It seems to prefer knowing what all the tests are and then tries to do
its own output management and parallelizing and such. We already have
our own runners. all_tests.go could actually be converted tidily, but
generate_build_files.py also needs to read it, and runner.go has very
specific needs.
Naming the target ninja -C build test would be nice, but CTest squats
that name and CMake grumps when you use a reserved name, so I've gone
with run_tests.
Change-Id: Ibd20ebd50febe1b4e91bb19921f3bbbd9fbcf66c
Reviewed-on: https://boringssl-review.googlesource.com/6270
Reviewed-by: Adam Langley <alangley@gmail.com>
2015-10-15 02:34:40 +01:00
|
|
|
if (NOT ${CMAKE_VERSION} VERSION_LESS "3.2")
|
|
|
|
# USES_TERMINAL is only available in CMake 3.2 or later.
|
|
|
|
set(MAYBE_USES_TERMINAL USES_TERMINAL)
|
|
|
|
endif()
|
|
|
|
|
|
|
|
add_custom_target(
|
|
|
|
run_tests
|
|
|
|
COMMAND ${GO_EXECUTABLE} run util/all_tests.go -build-dir
|
|
|
|
${CMAKE_BINARY_DIR}
|
2016-09-24 00:43:17 +01:00
|
|
|
COMMAND cd ssl/test/runner &&
|
|
|
|
${GO_EXECUTABLE} test -shim-path $<TARGET_FILE:bssl_shim>
|
|
|
|
${RUNNER_ARGS}
|
Add a run_tests target to run all tests.
It's very annoying having to remember the right incant every time I want
to switch around between my build, build-release, build-asan, etc.,
output directories.
Unfortunately, this target is pretty unfriendly without CMake 3.2+ (and
Ninja 1.5+). This combination gives a USES_TERMINAL flag to
add_custom_target which uses Ninja's "console" pool, otherwise the
output buffering gets in the way. Ubuntu LTS is still on an older CMake,
so do a version check in the meantime.
CMake also has its own test mechanism (CTest), but this doesn't use it.
It seems to prefer knowing what all the tests are and then tries to do
its own output management and parallelizing and such. We already have
our own runners. all_tests.go could actually be converted tidily, but
generate_build_files.py also needs to read it, and runner.go has very
specific needs.
Naming the target ninja -C build test would be nice, but CTest squats
that name and CMake grumps when you use a reserved name, so I've gone
with run_tests.
Change-Id: Ibd20ebd50febe1b4e91bb19921f3bbbd9fbcf66c
Reviewed-on: https://boringssl-review.googlesource.com/6270
Reviewed-by: Adam Langley <alangley@gmail.com>
2015-10-15 02:34:40 +01:00
|
|
|
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
|
|
|
|
DEPENDS all_tests bssl_shim
|
|
|
|
${MAYBE_USES_TERMINAL})
|