kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix -Wformat-nonliteral violation in ssl_cipher.c.

Browse Source 
Besides avoiding the -Wformat-nonliteral warning, it is easier to
review (changes to) the code when the format string is passed to the
function as a literal.

Change-Id: I5093ad4494d5ebeea3f2671509b916cd6c5fb173
Reviewed-on: https://boringssl-review.googlesource.com/6908
Reviewed-by: David Benjamin <davidben@google.com>
This commit is contained in:
Brian Smith 2016-01-17 09:18:26 -10:00 committed by David Benjamin
parent 6c22f542f4
commit 0687bdfc12
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ssl/ssl_cipher.c
View File

@ -1804,7 +1804,6 @@ const char *SSL_CIPHER_description(const SSL_CIPHER *cipher, char *buf,
int len) { int len) {
const char *kx, *au, *enc, *mac; const char *kx, *au, *enc, *mac;
uint32_t alg_mkey, alg_auth, alg_enc, alg_mac; uint32_t alg_mkey, alg_auth, alg_enc, alg_mac;
static const char *format = "%-23s Kx=%-8s Au=%-4s Enc=%-9s Mac=%-4s\n";
alg_mkey = cipher->algorithm_mkey; alg_mkey = cipher->algorithm_mkey;
alg_auth = cipher->algorithm_auth; alg_auth = cipher->algorithm_auth;
@ -1928,7 +1927,8 @@ const char *SSL_CIPHER_description(const SSL_CIPHER *cipher, char *buf,
return "Buffer too small"; return "Buffer too small";
} }
BIO_snprintf(buf, len, format, cipher->name, kx, au, enc, mac); BIO_snprintf(buf, len, "%-23s Kx=%-8s Au=%-4s Enc=%-9s Mac=%-4s\n",
cipher->name, kx, au, enc, mac);
return buf; return buf;
} }