From 09d68c98c0470521b4bc33e486db7a9f9546c6a5 Mon Sep 17 00:00:00 2001 From: Adam Langley Date: Wed, 28 Oct 2015 18:08:10 -0700 Subject: [PATCH] Expand a comment. As a follow up to https://boringssl-review.googlesource.com/#/c/6340, this change expands a comment to note the reason for clearing a flag that I missed. Change-Id: Ib3cfecbb330f0ae7c46bf44286f4e6b407159fe8 Reviewed-on: https://boringssl-review.googlesource.com/6393 Reviewed-by: Adam Langley --- ssl/s3_clnt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ssl/s3_clnt.c b/ssl/s3_clnt.c index 12eb5e09..5ccce754 100644 --- a/ssl/s3_clnt.c +++ b/ssl/s3_clnt.c @@ -1456,7 +1456,9 @@ int ssl3_get_new_session_ticket(SSL *s) { if (CBS_len(&ticket) == 0) { /* RFC 5077 allows a server to change its mind and send no ticket after - * negotiating the extension. Behave as if no ticket was sent. */ + * negotiating the extension. The value of |tlsext_ticket_expected| is + * checked in |ssl_update_cache| so is cleared here to avoid an unnecessary + * update. */ s->tlsext_ticket_expected = 0; return 1; }