From f9c8d30897c0acdb8ba8358ae8c0970a65bd7e2d Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Tue, 5 Mar 2019 11:31:30 -0600 Subject: [PATCH] Remove SSL_get_structure_sizes. With all those structures made opaque, it's not really useful as a build sanity-check anymore. Update-Note: This function is removed, but I don't see any actual uses. Change-Id: Ib5640e778466da980596e7085d97104d22aa9d33 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/35184 Commit-Queue: David Benjamin Commit-Queue: Adam Langley Reviewed-by: Adam Langley --- include/openssl/ssl.h | 7 ------- ssl/ssl_lib.cc | 7 ------- 2 files changed, 14 deletions(-) diff --git a/include/openssl/ssl.h b/include/openssl/ssl.h index b28dcf68..5d8c5c00 100644 --- a/include/openssl/ssl.h +++ b/include/openssl/ssl.h @@ -3440,13 +3440,6 @@ OPENSSL_EXPORT uint64_t SSL_get_write_sequence(const SSL *ssl); // Obscure functions. -// SSL_get_structure_sizes returns the sizes of the SSL, SSL_CTX and -// SSL_SESSION structures so that a test can ensure that outside code agrees on -// these values. -OPENSSL_EXPORT void SSL_get_structure_sizes(size_t *ssl_size, - size_t *ssl_ctx_size, - size_t *ssl_session_size); - // SSL_CTX_set_msg_callback installs |cb| as the message callback for |ctx|. // This callback will be called when sending or receiving low-level record // headers, complete handshake messages, ChangeCipherSpec, and alerts. diff --git a/ssl/ssl_lib.cc b/ssl/ssl_lib.cc index a4f20444..d3e76d0f 100644 --- a/ssl/ssl_lib.cc +++ b/ssl/ssl_lib.cc @@ -2672,13 +2672,6 @@ int SSL_cutthrough_complete(const SSL *ssl) { return SSL_in_false_start(ssl); } -void SSL_get_structure_sizes(size_t *ssl_size, size_t *ssl_ctx_size, - size_t *ssl_session_size) { - *ssl_size = sizeof(SSL); - *ssl_ctx_size = sizeof(SSL_CTX); - *ssl_session_size = sizeof(SSL_SESSION); -} - int SSL_is_server(const SSL *ssl) { return ssl->server; } int SSL_is_dtls(const SSL *ssl) { return ssl->method->is_dtls; }