kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
abaef2e869
boringssl/crypto
History
David Benjamin abaef2e869 Fix omitted selector handling. 
The selector field could be omitted because it has a DEFAULT value.
In this case *sfld == NULL (sfld can never be NULL). This was not
noticed because this was never used in existing ASN.1 modules.

(Imported from upstream's c4210673313482edacede58d92e92c213d7a181a.)

svaldez and I stared at this for a while and we believe this change is
correct. It's also irrelevant because our only remaining ADB (ANY
DEFINED BY) table is POLICYQUALINFO which does not allow its selector to
be omitted. Also, if it did, it would be a slight change in behavior.
We'd switch from using POLICYQUALINFO's default_tt (filling in an
ASN1_ANY) to its null_tt (which doesn't exist, so error).

Change-Id: If6a929e3dafca18431775b01958d0dae1c09f3b4
Reviewed-on: https://boringssl-review.googlesource.com/8943
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2016-07-26 20:01:37 +00:00
..
aes Import (unreachable) bsaes-armv7.pl XTS fixes. 2016-07-26 19:47:12 +00:00
asn1 Fix omitted selector handling. 2016-07-26 20:01:37 +00:00
base64 Replace base64 decoding. 2016-05-26 17:59:10 +00:00
bio Inline bio_set. 2016-07-25 18:44:46 +00:00
bn Add mod_mul tests where M ≪ A and B. 2016-07-22 14:47:24 +00:00
buf Add BUF_MEM_reserve. 2016-05-18 19:09:06 +00:00
bytestring Check for overflow in CBB_add_u24. 2016-07-26 15:19:41 +00:00
chacha Switch perlasm calling convention. 2016-06-27 21:59:26 +00:00
cipher Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
cmac Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
conf Add missing internal includes. 2016-03-20 16:38:54 +00:00
curve25519 Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
des
dh Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
digest Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
dsa Don't rely on BN_FLG_CONSTTIME in the DSA code. 2016-06-20 17:17:41 +00:00
ec Ensure result affine coordinates in nistz256 are fully reduced. 2016-07-19 22:26:53 +00:00
ecdh
ecdsa Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
engine
err Add TLS 1.3 1-RTT. 2016-07-18 09:54:46 +00:00
evp Change |EVP_PKEY_up_ref| to return int. 2016-07-12 17:55:41 +00:00
hkdf Const-correct HKDF_expand. 2016-07-16 07:55:19 +00:00
hmac Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
lhash Use non-deprecated methods on windows. 2016-05-19 20:30:50 +00:00
md4 Revert md_len removal from SHA256_CTX and SHA512_CTX. 2016-04-27 19:01:23 +00:00
md5 Switch perlasm calling convention. 2016-06-27 21:59:26 +00:00
modes Switch perlasm calling convention. 2016-06-27 21:59:26 +00:00
newhope Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
obj Split unlock functions into read/write variants. 2016-05-31 21:09:29 +00:00
pem Reject inappropriate private key encryption ciphers. 2016-05-03 16:30:08 +00:00
perlasm Sync x86 perlasm drivers with upstream master. 2016-06-27 22:00:51 +00:00
pkcs8 Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
poly1305 Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
rand Define RAND_cleanup in one place only 2016-07-11 17:02:45 +00:00
rc4 Switch perlasm calling convention. 2016-06-27 21:59:26 +00:00
rsa RSA_marshal_private_key: add missing CBB_flush() 2016-07-13 03:49:41 +00:00
sha Switch perlasm calling convention. 2016-06-27 21:59:26 +00:00
stack Fix stack macro const-ness. 2016-05-13 18:24:57 +00:00
test Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
x509 Fix an error path leak in int X509_ATTRIBUTE_set1_data() 2016-07-26 19:53:44 +00:00
x509v3 Fix an error path leak in do_ext_nconf() 2016-07-26 19:11:01 +00:00
CMakeLists.txt Switch perlasm calling convention. 2016-06-27 21:59:26 +00:00
constant_time_test.c
cpu-aarch64-linux.c Rewrite ARM feature detection. 2016-03-26 04:54:44 +00:00
cpu-arm-linux.c Make CRYPTO_is_NEON_capable aware of the buggy CPU. 2016-04-28 16:42:21 +00:00
cpu-arm.c Rewrite ARM feature detection. 2016-03-26 04:54:44 +00:00
cpu-intel.c Wrap MSVC-only warning pragmas in a macro. 2016-06-09 21:29:36 +00:00
crypto.c Add no-op function ENGINE_register_all_complete. 2016-07-12 17:54:41 +00:00
ex_data.c Split unlock functions into read/write variants. 2016-05-31 21:09:29 +00:00
internal.h Remove compatibility 'inline' define. 2016-06-27 22:16:03 +00:00
mem.c Breaking news: 1998 has come and gone. 2016-07-11 23:51:47 +00:00
refcount_c11.c
refcount_lock.c Split unlock functions into read/write variants. 2016-05-31 21:09:29 +00:00
refcount_test.c
thread_none.c Split unlock functions into read/write variants. 2016-05-31 21:09:29 +00:00
thread_pthread.c Split unlock functions into read/write variants. 2016-05-31 21:09:29 +00:00
thread_test.c Wrap MSVC-only warning pragmas in a macro. 2016-06-09 21:29:36 +00:00
thread_win.c Wrap MSVC-only warning pragmas in a macro. 2016-06-09 21:29:36 +00:00
thread.c Remove a bunch of unnecessary includes. 2016-06-28 20:31:14 +00:00
time_support.c Remove some mingw support cruft. 2016-01-25 23:05:45 +00:00