From a1fb93da7318e11281b8833df46e663e980f38c4 Mon Sep 17 00:00:00 2001 From: Thom Wiggers Date: Wed, 11 Dec 2019 08:51:26 +0100 Subject: [PATCH] Don't use const integer arguments --- crypto_sign/dilithium2/clean/rounding.c | 6 ++---- crypto_sign/dilithium3/clean/rounding.c | 6 ++---- crypto_sign/dilithium4/clean/rounding.c | 6 ++---- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/crypto_sign/dilithium2/clean/rounding.c b/crypto_sign/dilithium2/clean/rounding.c index 6272c927..ac7ce1e9 100644 --- a/crypto_sign/dilithium2/clean/rounding.c +++ b/crypto_sign/dilithium2/clean/rounding.c @@ -1,5 +1,3 @@ -#include - #include "params.h" #include "rounding.h" @@ -77,7 +75,7 @@ uint32_t PQCLEAN_DILITHIUM2_CLEAN_decompose(uint32_t a, uint32_t *a0) { * * Returns 1 if high bits of a and b differ and 0 otherwise. **************************************************/ -unsigned int PQCLEAN_DILITHIUM2_CLEAN_make_hint(const uint32_t a0, const uint32_t a1) { +unsigned int PQCLEAN_DILITHIUM2_CLEAN_make_hint(uint32_t a0, uint32_t a1) { if (a0 <= GAMMA2 || a0 > Q - GAMMA2 || (a0 == Q - GAMMA2 && a1 == 0)) { return 0; } @@ -95,7 +93,7 @@ unsigned int PQCLEAN_DILITHIUM2_CLEAN_make_hint(const uint32_t a0, const uint32_ * * Returns corrected high bits. **************************************************/ -uint32_t PQCLEAN_DILITHIUM2_CLEAN_use_hint(const uint32_t a, const unsigned int hint) { +uint32_t PQCLEAN_DILITHIUM2_CLEAN_use_hint(uint32_t a, unsigned int hint) { uint32_t a0, a1; a1 = PQCLEAN_DILITHIUM2_CLEAN_decompose(a, &a0); diff --git a/crypto_sign/dilithium3/clean/rounding.c b/crypto_sign/dilithium3/clean/rounding.c index 6dcb8101..2da5f5d1 100644 --- a/crypto_sign/dilithium3/clean/rounding.c +++ b/crypto_sign/dilithium3/clean/rounding.c @@ -1,5 +1,3 @@ -#include - #include "params.h" #include "rounding.h" @@ -77,7 +75,7 @@ uint32_t PQCLEAN_DILITHIUM3_CLEAN_decompose(uint32_t a, uint32_t *a0) { * * Returns 1 if high bits of a and b differ and 0 otherwise. **************************************************/ -unsigned int PQCLEAN_DILITHIUM3_CLEAN_make_hint(const uint32_t a0, const uint32_t a1) { +unsigned int PQCLEAN_DILITHIUM3_CLEAN_make_hint(uint32_t a0, uint32_t a1) { if (a0 <= GAMMA2 || a0 > Q - GAMMA2 || (a0 == Q - GAMMA2 && a1 == 0)) { return 0; } @@ -95,7 +93,7 @@ unsigned int PQCLEAN_DILITHIUM3_CLEAN_make_hint(const uint32_t a0, const uint32_ * * Returns corrected high bits. **************************************************/ -uint32_t PQCLEAN_DILITHIUM3_CLEAN_use_hint(const uint32_t a, const unsigned int hint) { +uint32_t PQCLEAN_DILITHIUM3_CLEAN_use_hint(uint32_t a, unsigned int hint) { uint32_t a0, a1; a1 = PQCLEAN_DILITHIUM3_CLEAN_decompose(a, &a0); diff --git a/crypto_sign/dilithium4/clean/rounding.c b/crypto_sign/dilithium4/clean/rounding.c index f0d717b4..27c35122 100644 --- a/crypto_sign/dilithium4/clean/rounding.c +++ b/crypto_sign/dilithium4/clean/rounding.c @@ -1,5 +1,3 @@ -#include - #include "params.h" #include "rounding.h" @@ -77,7 +75,7 @@ uint32_t PQCLEAN_DILITHIUM4_CLEAN_decompose(uint32_t a, uint32_t *a0) { * * Returns 1 if high bits of a and b differ and 0 otherwise. **************************************************/ -unsigned int PQCLEAN_DILITHIUM4_CLEAN_make_hint(const uint32_t a0, const uint32_t a1) { +unsigned int PQCLEAN_DILITHIUM4_CLEAN_make_hint(uint32_t a0, uint32_t a1) { if (a0 <= GAMMA2 || a0 > Q - GAMMA2 || (a0 == Q - GAMMA2 && a1 == 0)) { return 0; } @@ -95,7 +93,7 @@ unsigned int PQCLEAN_DILITHIUM4_CLEAN_make_hint(const uint32_t a0, const uint32_ * * Returns corrected high bits. **************************************************/ -uint32_t PQCLEAN_DILITHIUM4_CLEAN_use_hint(const uint32_t a, const unsigned int hint) { +uint32_t PQCLEAN_DILITHIUM4_CLEAN_use_hint(uint32_t a, unsigned int hint) { uint32_t a0, a1; a1 = PQCLEAN_DILITHIUM4_CLEAN_decompose(a, &a0);