From f25824246f65729620e6ea5b78894134b1a78c13 Mon Sep 17 00:00:00 2001 From: Thom Wiggers Date: Mon, 4 Mar 2019 16:56:40 +0100 Subject: [PATCH] small improvements of reporting --- test/test_functest.py | 2 +- test/test_metadata.py | 2 +- test/test_symbol_namespace.py | 7 +++---- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/test/test_functest.py b/test/test_functest.py index 1ec92a8d..465b639a 100644 --- a/test/test_functest.py +++ b/test/test_functest.py @@ -43,7 +43,7 @@ def check_functest(implementation): def check_functest_sanitizers(implementation): env = None if platform.machine() == 'ppc' and os.environ.get('CC', 'gcc') == 'clang': - raise unittest.SkipTest() + raise unittest.SkipTest("Clang does not support ASAN on ppc") elif platform.machine() in ['armv7l', 'aarch64']: env = {'ASAN_OPTIONS': 'detect_leaks=0'} else: diff --git a/test/test_metadata.py b/test/test_metadata.py index b5112576..71ca7798 100644 --- a/test/test_metadata.py +++ b/test/test_metadata.py @@ -23,7 +23,7 @@ def check_metadata(scheme): specification = itertools.chain(specification, SIGNATURE_FIELDS.items()) else: - assert(False) + assert False, "Wrong type of metadata" check_spec(copy.deepcopy(metadata), specification) diff --git a/test/test_symbol_namespace.py b/test/test_symbol_namespace.py index 654d2dda..5d6ea9a0 100644 --- a/test/test_symbol_namespace.py +++ b/test/test_symbol_namespace.py @@ -10,18 +10,17 @@ import unittest def test_symbol_namespace(): - if sys.platform not in ['linux', 'darwin']: - raise unittest.SkipTest() for scheme in pqclean.Scheme.all_schemes(): for implementation in scheme.implementations: yield check_symbol_namespace, implementation def check_symbol_namespace(implementation): + if sys.platform not in ['linux', 'darwin']: + raise unittest.SkipTest("Unsupported platform") helpers.make(working_dir=implementation.path()) out = helpers.run_subprocess( - ['nm', '-g', 'lib{}_{}.a'.format(implementation.scheme.name, - implementation.name)], + ['nm', '-g', implementation.libname()], implementation.path() )