From 1938f78bf1a83c51e1a3b99af9d50c06d5bd3288 Mon Sep 17 00:00:00 2001 From: Thom Wiggers Date: Wed, 27 Feb 2019 14:55:06 +0100 Subject: [PATCH] Pull request template draft [ci skip] --- .github/pull_request_template.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..c828dc66 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,17 @@ + + + + + +## Manually checked properties + + +* [ ] `#ifdef`s only for header encapsulation +* [ ] `api.h` does not include other files +* [ ] No stringification macros +* [ ] Output-parameter pointers in functions are on the left +* [ ] Negative return values on failure of API functions (within restrictions of FO transform). +* [ ] `const` arguments are labeled as `const` +* [ ] (optional) All integer types are of fixed size, using `stdint.h` types (including `uint8_t` instead of `unsigned char`) +* [ ] Integers used for indexing are of size `size_t` +* [ ] variable declarations at the beginning (except in `for (size_t i=...`)