diff --git a/README.md b/README.md index 40e2ea8a..8c31d706 100644 --- a/README.md +++ b/README.md @@ -41,6 +41,8 @@ _The checking of items on this list is still being developed. Checked items shou * [ ] `aes.c` * [x] `randombytes.c` * [ ] API functions return `0` on success, negative on failure + * [x] 0 on success + * [ ] Negative on failure (currently: partially) * [ ] No dynamic memory allocations * [ ] No branching on secret data (dynamically checked using valgrind) * [ ] No access to secret memory locations (dynamically checked using valgrind) diff --git a/test/crypto_kem/functest.c b/test/crypto_kem/functest.c index f4f970c5..7f4c7beb 100644 --- a/test/crypto_kem/functest.c +++ b/test/crypto_kem/functest.c @@ -29,6 +29,12 @@ static int check_canary(const unsigned char *d) { #define crypto_kem_enc NAMESPACE(crypto_kem_enc) #define crypto_kem_dec NAMESPACE(crypto_kem_dec) +#define RETURNS_ZERO(f) \ + if ((f) != 0) { \ + puts(#f " returned non-zero returncode"); \ + return -1; \ + } + static int test_keys(void) { unsigned char key_a[CRYPTO_BYTES + 16], key_b[CRYPTO_BYTES + 16]; unsigned char pk[CRYPTO_PUBLICKEYBYTES + 16]; @@ -50,25 +56,26 @@ static int test_keys(void) { for (i = 0; i < NTESTS; i++) { // Alice generates a public key - crypto_kem_keypair(pk + 8, sk_a + 8); + RETURNS_ZERO(crypto_kem_keypair(pk + 8, sk_a + 8)); // Bob derives a secret key and creates a response - crypto_kem_enc(sendb + 8, key_b + 8, pk + 8); + RETURNS_ZERO(crypto_kem_enc(sendb + 8, key_b + 8, pk + 8)); // Alice uses Bobs response to get her secret key - crypto_kem_dec(key_a + 8, sendb + 8, sk_a + 8); + RETURNS_ZERO(crypto_kem_dec(key_a + 8, sendb + 8, sk_a + 8)); if (memcmp(key_a + 8, key_b + 8, CRYPTO_BYTES) != 0) { printf("ERROR KEYS\n"); - return 1; + return -1; } + if (check_canary(key_a) || check_canary(key_a + sizeof(key_a) - 8) || check_canary(key_b) || check_canary(key_b + sizeof(key_b) - 8) || check_canary(pk) || check_canary(pk + sizeof(pk) - 8) || check_canary(sendb) || check_canary(sendb + sizeof(sendb) - 8) || check_canary(sk_a) || check_canary(sk_a + sizeof(sk_a) - 8)) { printf("ERROR canary overwritten\n"); - return 1; + return -1; } } @@ -81,19 +88,23 @@ static int test_invalid_sk_a(void) { unsigned char pk[CRYPTO_PUBLICKEYBYTES]; unsigned char sendb[CRYPTO_CIPHERTEXTBYTES]; int i; + int returncode; for (i = 0; i < NTESTS; i++) { // Alice generates a public key - crypto_kem_keypair(pk, sk_a); + RETURNS_ZERO(crypto_kem_keypair(pk, sk_a)); // Bob derives a secret key and creates a response - crypto_kem_enc(sendb, key_b, pk); + RETURNS_ZERO(crypto_kem_enc(sendb, key_b, pk)); // Replace secret key with random values randombytes(sk_a, CRYPTO_SECRETKEYBYTES); // Alice uses Bobs response to get her secret key - crypto_kem_dec(key_a, sendb, sk_a); + if ((returncode = crypto_kem_dec(key_a, sendb, sk_a)) > -1) { + printf("ERROR failing crypto_kem_dec returned %d instead of negative code\n", returncode); + return -1; + } if (!memcmp(key_a, key_b, CRYPTO_BYTES)) { printf("ERROR invalid sk_a\n"); @@ -111,21 +122,25 @@ static int test_invalid_ciphertext(void) { unsigned char sendb[CRYPTO_CIPHERTEXTBYTES]; int i; size_t pos; + int returncode; for (i = 0; i < NTESTS; i++) { randombytes((unsigned char *)&pos, sizeof(size_t)); // Alice generates a public key - crypto_kem_keypair(pk, sk_a); + RETURNS_ZERO(crypto_kem_keypair(pk, sk_a)); // Bob derives a secret key and creates a response - crypto_kem_enc(sendb, key_b, pk); + RETURNS_ZERO(crypto_kem_enc(sendb, key_b, pk)); // Change some byte in the ciphertext (i.e., encapsulated key) sendb[pos % CRYPTO_CIPHERTEXTBYTES] ^= 23; // Alice uses Bobs response to get her secret key - crypto_kem_dec(key_a, sendb, sk_a); + if ((returncode = crypto_kem_dec(key_a, sendb, sk_a)) > -1) { + printf("ERROR crypto_kem_dec should fail (negative returncode) but returned %d\n", returncode); + return -1; + } if (!memcmp(key_a, key_b, CRYPTO_BYTES)) { printf("ERROR invalid ciphertext\n"); diff --git a/test/crypto_sign/functest.c b/test/crypto_sign/functest.c index 60158e64..edd484c9 100644 --- a/test/crypto_sign/functest.c +++ b/test/crypto_sign/functest.c @@ -30,6 +30,13 @@ static int check_canary(const unsigned char *d) { #define crypto_sign NAMESPACE(crypto_sign) #define crypto_sign_open NAMESPACE(crypto_sign_open) +#define RETURNS_ZERO(f) \ + if ((f) != 0) { \ + puts("(f) returned non-zero returncode"); \ + return -1; \ + } + + static int test_sign(void) { unsigned char pk[CRYPTO_PUBLICKEYBYTES + 16]; unsigned char sk[CRYPTO_SECRETKEYBYTES + 16]; @@ -38,6 +45,7 @@ static int test_sign(void) { unsigned long long mlen; unsigned long long smlen; + int returncode; int i; write_canary(pk); @@ -50,15 +58,18 @@ static int test_sign(void) { write_canary(m + sizeof(m) - 8); for (i = 0; i < NTESTS; i++) { - crypto_sign_keypair(pk + 8, sk + 8); + RETURNS_ZERO(crypto_sign_keypair(pk + 8, sk + 8)); randombytes(m + 8, MLEN); - crypto_sign(sm + 8, &smlen, m + 8, MLEN, sk + 8); + RETURNS_ZERO(crypto_sign(sm + 8, &smlen, m + 8, MLEN, sk + 8)); // By relying on m == sm we prevent having to allocate CRYPTO_BYTES // twice - if (crypto_sign_open(sm + 8, &mlen, sm + 8, smlen, pk + 8)) { + if ((returncode = crypto_sign_open(sm + 8, &mlen, sm + 8, smlen, pk + 8)) != 0) { printf("ERROR Signature did not verify correctly!\n"); + if (returncode > 0) { + puts("ERROR return code should be < 0 on failure"); + } return 1; } if (check_canary(pk) || check_canary(pk + sizeof(pk) - 8) || @@ -83,21 +94,26 @@ static int test_wrong_pk(void) { unsigned long long mlen; unsigned long long smlen; + int returncode; + int i; for (i = 0; i < NTESTS; i++) { - crypto_sign_keypair(pk2, sk); + RETURNS_ZERO(crypto_sign_keypair(pk2, sk)); - crypto_sign_keypair(pk, sk); + RETURNS_ZERO(crypto_sign_keypair(pk, sk)); randombytes(m, MLEN); - crypto_sign(sm, &smlen, m, MLEN, sk); + RETURNS_ZERO(crypto_sign(sm, &smlen, m, MLEN, sk)); // By relying on m == sm we prevent having to allocate CRYPTO_BYTES // twice - if (!crypto_sign_open(sm, &mlen, sm, smlen, pk2)) { + if (!(returncode = crypto_sign_open(sm, &mlen, sm, smlen, pk2))) { printf("ERROR Signature did verify correctly under wrong public " "key!\n"); + if (returncode > 0) { + puts("ERROR return code should be < 0"); + } return 1; } }