From 829d15bde3fdd52d2045c84d9b38e460c6056596 Mon Sep 17 00:00:00 2001 From: Kris Kwiatkowski Date: Mon, 26 Apr 2021 10:05:53 +0100 Subject: [PATCH] fix memory overrun --- src/kem/sike/includes/sike/sike.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/kem/sike/includes/sike/sike.h b/src/kem/sike/includes/sike/sike.h index ca0d03d7..869eab6a 100644 --- a/src/kem/sike/includes/sike/sike.h +++ b/src/kem/sike/includes/sike/sike.h @@ -49,13 +49,13 @@ const uint8_t priv_key[SIKE_PRV_BYTESZ]); // boilerplate needed for integration -#define PQCLEAN_SIKE434_CLEAN_CRYPTO_SECRETKEYBYTES SIKE_PRV_BYTESZ+SIKE_MSG_BYTESZ +#define PQCLEAN_SIKE434_CLEAN_CRYPTO_SECRETKEYBYTES SIKE_PRV_BYTESZ+SIKE_MSG_BYTESZ+SIKE_PUB_BYTESZ #define PQCLEAN_SIKE434_CLEAN_CRYPTO_PUBLICKEYBYTES SIKE_PUB_BYTESZ #define PQCLEAN_SIKE434_CLEAN_CRYPTO_CIPHERTEXTBYTES SIKE_CT_BYTESZ #define PQCLEAN_SIKE434_CLEAN_CRYPTO_BYTES SIKE_SS_BYTESZ #define PQCLEAN_SIKE434_CLEAN_CRYPTO_ALGNAME "SIKE/p434" -#define PQCLEAN_SIKE434_AVX2_CRYPTO_SECRETKEYBYTES SIKE_PRV_BYTESZ+SIKE_MSG_BYTESZ +#define PQCLEAN_SIKE434_AVX2_CRYPTO_SECRETKEYBYTES SIKE_PRV_BYTESZ+SIKE_MSG_BYTESZ+SIKE_PUB_BYTESZ #define PQCLEAN_SIKE434_AVX2_CRYPTO_PUBLICKEYBYTES SIKE_PUB_BYTESZ #define PQCLEAN_SIKE434_AVX2_CRYPTO_CIPHERTEXTBYTES SIKE_CT_BYTESZ #define PQCLEAN_SIKE434_AVX2_CRYPTO_BYTES SIKE_SS_BYTESZ @@ -64,7 +64,6 @@ static inline int PQCLEAN_SIKE434_CLEAN_crypto_kem_keypair(uint8_t *pk, uint8_t *sk) { SIKE_keypair(sk, pk); // KATs require the public key to be concatenated after private key - // OZAPTF: maybe change KAT tester memcpy(&sk[SIKE_MSG_BYTESZ+SIKE_PRV_BYTESZ], pk, SIKE_PUB_BYTESZ); return 0; }