From 1a30048f28482c0658374d3ddcdcb8557840b884 Mon Sep 17 00:00:00 2001 From: Adam Langley Date: Tue, 11 Oct 2016 14:45:29 -0700 Subject: [PATCH] crypto/tls: fix printing of OpenSSL output when updating a test fails. When updating the test data against OpenSSL, the handshake can fail and the stdout/stderr output of OpenSSL is very useful in finding out why. However, printing that output has been broken for some time because its no longer sent to a byte.Buffer. This change fixes that. Change-Id: I6f846c7dc80f1ccee9fa1be36f0b579b3754e05f Reviewed-on: https://go-review.googlesource.com/30823 Reviewed-by: Brad Fitzpatrick --- handshake_client_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/handshake_client_test.go b/handshake_client_test.go index 23bf236..165ed4b 100644 --- a/handshake_client_test.go +++ b/handshake_client_test.go @@ -412,7 +412,7 @@ func (test *clientTest) run(t *testing.T, write bool) { childProcess.Process.Kill() childProcess.Wait() if len(recordingConn.flows) < 3 { - childProcess.Stdout.(*bytes.Buffer).WriteTo(os.Stdout) + os.Stdout.Write(childProcess.Stdout.(*opensslOutputSink).all) t.Fatalf("Client connection didn't work") } recordingConn.WriteTo(out)