From 8ee5e4091a54e239feadbdc05419783eac6f703f Mon Sep 17 00:00:00 2001 From: Adam Langley Date: Tue, 31 Jan 2012 11:22:47 -0500 Subject: [PATCH] crypto/tls: better error message when connecting to SSLv3 servers. We support SSLv3 as a server but not as a client (and we don't want to support it as a client). This change fixes the error message when connecting to an SSLv3 server since SSLv3 support on the server side made mutualVersion accept SSLv3. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5545073 --- handshake_client.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/handshake_client.go b/handshake_client.go index 632ceea..687e5ef 100644 --- a/handshake_client.go +++ b/handshake_client.go @@ -59,7 +59,8 @@ func (c *Conn) clientHandshake() error { finishedHash.Write(serverHello.marshal()) vers, ok := mutualVersion(serverHello.vers) - if !ok { + if !ok || vers < versionTLS10 { + // TLS 1.0 is the minimum version supported as a client. return c.sendAlert(alertProtocolVersion) } c.vers = vers