From d20745552cb3e46886a5b8a2c5730540fa11e213 Mon Sep 17 00:00:00 2001 From: Filippo Valsorda Date: Thu, 7 Jun 2018 16:24:52 -0400 Subject: [PATCH] crypto/tls: expand docs on client-side session ticket support Users are sometimes confused why session tickets are not enabled even if SessionTicketsDisabled is false. Change-Id: I3b783d2cf3eed693a3ad6acb40a8003db7e0b648 Reviewed-on: https://go-review.googlesource.com/117255 Reviewed-by: Adam Langley --- common.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/common.go b/common.go index 4505723..48c4fdb 100644 --- a/common.go +++ b/common.go @@ -547,7 +547,8 @@ type Config struct { PreferServerCipherSuites bool // SessionTicketsDisabled may be set to true to disable session ticket - // (resumption) support. + // (resumption) support. Note that on clients, session ticket support is + // also disabled if ClientSessionCache is nil. SessionTicketsDisabled bool // SessionTicketKey is used by TLS servers to provide session @@ -561,7 +562,7 @@ type Config struct { SessionTicketKey [32]byte // ClientSessionCache is a cache of ClientSessionState entries for TLS - // session resumption. + // session resumption. It is only used by clients. ClientSessionCache ClientSessionCache // MinVersion contains the minimum SSL/TLS version that is acceptable.