You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

x_algor.c 5.1 KiB

Fix various certificate fingerprint issues. By using non-DER or invalid encodings outside the signed portion of a certificate the fingerprint can be changed without breaking the signature. Although no details of the signed portion of the certificate can be changed this can cause problems with some applications: e.g. those using the certificate fingerprint for blacklists. 1. Reject signatures with non zero unused bits. If the BIT STRING containing the signature has non zero unused bits reject the signature. All current signature algorithms require zero unused bits. 2. Check certificate algorithm consistency. Check the AlgorithmIdentifier inside TBS matches the one in the certificate signature. NB: this will result in signature failure errors for some broken certificates. 3. Check DSA/ECDSA signatures use DER. Reencode DSA/ECDSA signatures and compare with the original received signature. Return an error if there is a mismatch. This will reject various cases including garbage after signature (thanks to Antti Karjalainen and Tuomo Untinen from the Codenomicon CROSS program for discovering this case) and use of BER or invalid ASN.1 INTEGERs (negative or with leading zeroes). CVE-2014-8275 (Imported from upstream's 85cfc188c06bd046420ae70dd6e302f9efe022a9 and 4c52816d35681c0533c25fdd3abb4b7c6962302d) Change-Id: Ic901aea8ea6457df27dc542a11c30464561e322b Reviewed-on: https://boringssl-review.googlesource.com/2783 Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: Adam Langley <agl@google.com>
9 vuotta sitten
Fix various certificate fingerprint issues. By using non-DER or invalid encodings outside the signed portion of a certificate the fingerprint can be changed without breaking the signature. Although no details of the signed portion of the certificate can be changed this can cause problems with some applications: e.g. those using the certificate fingerprint for blacklists. 1. Reject signatures with non zero unused bits. If the BIT STRING containing the signature has non zero unused bits reject the signature. All current signature algorithms require zero unused bits. 2. Check certificate algorithm consistency. Check the AlgorithmIdentifier inside TBS matches the one in the certificate signature. NB: this will result in signature failure errors for some broken certificates. 3. Check DSA/ECDSA signatures use DER. Reencode DSA/ECDSA signatures and compare with the original received signature. Return an error if there is a mismatch. This will reject various cases including garbage after signature (thanks to Antti Karjalainen and Tuomo Untinen from the Codenomicon CROSS program for discovering this case) and use of BER or invalid ASN.1 INTEGERs (negative or with leading zeroes). CVE-2014-8275 (Imported from upstream's 85cfc188c06bd046420ae70dd6e302f9efe022a9 and 4c52816d35681c0533c25fdd3abb4b7c6962302d) Change-Id: Ic901aea8ea6457df27dc542a11c30464561e322b Reviewed-on: https://boringssl-review.googlesource.com/2783 Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: Adam Langley <agl@google.com>
9 vuotta sitten
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151
  1. /*
  2. * Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL project
  3. * 2000.
  4. */
  5. /* ====================================================================
  6. * Copyright (c) 2000 The OpenSSL Project. All rights reserved.
  7. *
  8. * Redistribution and use in source and binary forms, with or without
  9. * modification, are permitted provided that the following conditions
  10. * are met:
  11. *
  12. * 1. Redistributions of source code must retain the above copyright
  13. * notice, this list of conditions and the following disclaimer.
  14. *
  15. * 2. Redistributions in binary form must reproduce the above copyright
  16. * notice, this list of conditions and the following disclaimer in
  17. * the documentation and/or other materials provided with the
  18. * distribution.
  19. *
  20. * 3. All advertising materials mentioning features or use of this
  21. * software must display the following acknowledgment:
  22. * "This product includes software developed by the OpenSSL Project
  23. * for use in the OpenSSL Toolkit. (http://www.OpenSSL.org/)"
  24. *
  25. * 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to
  26. * endorse or promote products derived from this software without
  27. * prior written permission. For written permission, please contact
  28. * licensing@OpenSSL.org.
  29. *
  30. * 5. Products derived from this software may not be called "OpenSSL"
  31. * nor may "OpenSSL" appear in their names without prior written
  32. * permission of the OpenSSL Project.
  33. *
  34. * 6. Redistributions of any form whatsoever must retain the following
  35. * acknowledgment:
  36. * "This product includes software developed by the OpenSSL Project
  37. * for use in the OpenSSL Toolkit (http://www.OpenSSL.org/)"
  38. *
  39. * THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY
  40. * EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  41. * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  42. * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE OpenSSL PROJECT OR
  43. * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  44. * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
  45. * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  46. * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  47. * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
  48. * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  49. * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
  50. * OF THE POSSIBILITY OF SUCH DAMAGE.
  51. * ====================================================================
  52. *
  53. * This product includes cryptographic software written by Eric Young
  54. * (eay@cryptsoft.com). This product includes software written by Tim
  55. * Hudson (tjh@cryptsoft.com). */
  56. #include <openssl/x509.h>
  57. #include <openssl/asn1.h>
  58. #include <openssl/asn1t.h>
  59. #include <openssl/digest.h>
  60. #include <openssl/obj.h>
  61. ASN1_SEQUENCE(X509_ALGOR) = {
  62. ASN1_SIMPLE(X509_ALGOR, algorithm, ASN1_OBJECT),
  63. ASN1_OPT(X509_ALGOR, parameter, ASN1_ANY)
  64. } ASN1_SEQUENCE_END(X509_ALGOR)
  65. ASN1_ITEM_TEMPLATE(X509_ALGORS) =
  66. ASN1_EX_TEMPLATE_TYPE(ASN1_TFLG_SEQUENCE_OF, 0, algorithms, X509_ALGOR)
  67. ASN1_ITEM_TEMPLATE_END(X509_ALGORS)
  68. IMPLEMENT_ASN1_FUNCTIONS(X509_ALGOR)
  69. IMPLEMENT_ASN1_ENCODE_FUNCTIONS_fname(X509_ALGORS, X509_ALGORS, X509_ALGORS)
  70. IMPLEMENT_ASN1_DUP_FUNCTION(X509_ALGOR)
  71. IMPLEMENT_ASN1_SET_OF(X509_ALGOR)
  72. int X509_ALGOR_set0(X509_ALGOR *alg, const ASN1_OBJECT *aobj, int ptype,
  73. void *pval)
  74. {
  75. if (!alg)
  76. return 0;
  77. if (ptype != V_ASN1_UNDEF) {
  78. if (alg->parameter == NULL)
  79. alg->parameter = ASN1_TYPE_new();
  80. if (alg->parameter == NULL)
  81. return 0;
  82. }
  83. if (alg) {
  84. if (alg->algorithm)
  85. ASN1_OBJECT_free(alg->algorithm);
  86. alg->algorithm = (ASN1_OBJECT *)aobj;
  87. }
  88. if (ptype == 0)
  89. return 1;
  90. if (ptype == V_ASN1_UNDEF) {
  91. if (alg->parameter) {
  92. ASN1_TYPE_free(alg->parameter);
  93. alg->parameter = NULL;
  94. }
  95. } else
  96. ASN1_TYPE_set(alg->parameter, ptype, pval);
  97. return 1;
  98. }
  99. void X509_ALGOR_get0(ASN1_OBJECT **paobj, int *pptype, void **ppval,
  100. X509_ALGOR *algor)
  101. {
  102. if (paobj)
  103. *paobj = algor->algorithm;
  104. if (pptype) {
  105. if (algor->parameter == NULL) {
  106. *pptype = V_ASN1_UNDEF;
  107. return;
  108. } else
  109. *pptype = algor->parameter->type;
  110. if (ppval)
  111. *ppval = algor->parameter->value.ptr;
  112. }
  113. }
  114. /* Set up an X509_ALGOR DigestAlgorithmIdentifier from an EVP_MD */
  115. void X509_ALGOR_set_md(X509_ALGOR *alg, const EVP_MD *md)
  116. {
  117. int param_type;
  118. if (EVP_MD_flags(md) & EVP_MD_FLAG_DIGALGID_ABSENT)
  119. param_type = V_ASN1_UNDEF;
  120. else
  121. param_type = V_ASN1_NULL;
  122. X509_ALGOR_set0(alg, OBJ_nid2obj(EVP_MD_type(md)), param_type, NULL);
  123. }
  124. /*
  125. * X509_ALGOR_cmp returns 0 if |a| and |b| are equal and non-zero otherwise.
  126. */
  127. int X509_ALGOR_cmp(const X509_ALGOR *a, const X509_ALGOR *b)
  128. {
  129. int rv;
  130. rv = OBJ_cmp(a->algorithm, b->algorithm);
  131. if (rv)
  132. return rv;
  133. if (!a->parameter && !b->parameter)
  134. return 0;
  135. return ASN1_TYPE_cmp(a->parameter, b->parameter);
  136. }