kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Actually use the u64 cast.

Browse Source 
The point was to remove the silly moduli.

Change-Id: I48c507c9dd1fc46e38e8991ed528b02b8da3dc1d
Reviewed-on: https://boringssl-review.googlesource.com/26044
Commit-Queue: Steven Valdez <svaldez@google.com>
Reviewed-by: Steven Valdez <svaldez@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
This commit is contained in:
David Benjamin 2018-02-16 14:39:42 -05:00 committed by CQ bot account: commit-bot@chromium.org
parent f16cd4278f
commit 085955c567
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
crypto/fipsmodule/modes/ccm.c
View File

@ -115,28 +115,28 @@ static int ccm128_init_state(const CCM128_CONTEXT *ctx,
// Cast to u64 to avoid the compiler complaining about invalid shifts. // Cast to u64 to avoid the compiler complaining about invalid shifts.
uint64_t aad_len_u64 = aad_len; uint64_t aad_len_u64 = aad_len;
if (aad_len_u64 < 0x10000 - 0x100) { if (aad_len_u64 < 0x10000 - 0x100) {
state->cmac.c[0] ^= (uint8_t)(aad_len >> 8); state->cmac.c[0] ^= (uint8_t)(aad_len_u64 >> 8);
state->cmac.c[1] ^= (uint8_t)aad_len; state->cmac.c[1] ^= (uint8_t)aad_len_u64;
i = 2; i = 2;
} else if (aad_len_u64 <= 0xffffffff) { } else if (aad_len_u64 <= 0xffffffff) {
state->cmac.c[0] ^= 0xff; state->cmac.c[0] ^= 0xff;
state->cmac.c[1] ^= 0xfe; state->cmac.c[1] ^= 0xfe;
state->cmac.c[2] ^= (uint8_t)(aad_len >> 24); state->cmac.c[2] ^= (uint8_t)(aad_len_u64 >> 24);
state->cmac.c[3] ^= (uint8_t)(aad_len >> 16); state->cmac.c[3] ^= (uint8_t)(aad_len_u64 >> 16);
state->cmac.c[4] ^= (uint8_t)(aad_len >> 8); state->cmac.c[4] ^= (uint8_t)(aad_len_u64 >> 8);
state->cmac.c[5] ^= (uint8_t)aad_len; state->cmac.c[5] ^= (uint8_t)aad_len_u64;
i = 6; i = 6;
} else { } else {
state->cmac.c[0] ^= 0xff; state->cmac.c[0] ^= 0xff;
state->cmac.c[1] ^= 0xff; state->cmac.c[1] ^= 0xff;
state->cmac.c[2] ^= (uint8_t)(aad_len >> (56 % (sizeof(aad_len) * 8))); state->cmac.c[2] ^= (uint8_t)(aad_len_u64 >> 56);
state->cmac.c[3] ^= (uint8_t)(aad_len >> (48 % (sizeof(aad_len) * 8))); state->cmac.c[3] ^= (uint8_t)(aad_len_u64 >> 48);
state->cmac.c[4] ^= (uint8_t)(aad_len >> (40 % (sizeof(aad_len) * 8))); state->cmac.c[4] ^= (uint8_t)(aad_len_u64 >> 40);
state->cmac.c[5] ^= (uint8_t)(aad_len >> (32 % (sizeof(aad_len) * 8))); state->cmac.c[5] ^= (uint8_t)(aad_len_u64 >> 32);
state->cmac.c[6] ^= (uint8_t)(aad_len >> 24); state->cmac.c[6] ^= (uint8_t)(aad_len_u64 >> 24);
state->cmac.c[7] ^= (uint8_t)(aad_len >> 16); state->cmac.c[7] ^= (uint8_t)(aad_len_u64 >> 16);
state->cmac.c[8] ^= (uint8_t)(aad_len >> 8); state->cmac.c[8] ^= (uint8_t)(aad_len_u64 >> 8);
state->cmac.c[9] ^= (uint8_t)aad_len; state->cmac.c[9] ^= (uint8_t)aad_len_u64;
i = 10; i = 10;
} }