kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Correctly free SSL_SESSIONs in ssl_test.

Browse Source 
That was silly.

Change-Id: I375c04f725cbb75f9e04fce386e20c4de5e7ae0c
Reviewed-on: https://boringssl-review.googlesource.com/6352
Reviewed-by: Adam Langley <alangley@gmail.com>
This commit is contained in:
David Benjamin 2015-10-26 15:45:39 -04:00 committed by Adam Langley
parent 12f7737d32
commit 0a870c2f7e
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ssl/ssl_test.cc
View File

@ -877,19 +877,19 @@ static ScopedSSL_SESSION CreateTestSession(uint32_t number) {
// TODO(davidben): Switch this to a |std::vector<ScopedSSL_SESSION>| once we can
// rely on a move-aware |std::vector|.
template <class T>
class ScopedVector {
class ScopedSessionVector {
public:
explicit ScopedVector(std::vector<T*> *v) : v_(v) {}
explicit ScopedSessionVector(std::vector<SSL_SESSION*> *sessions)
: sessions_(sessions) {}
~ScopedVector() {
for (T *t : *v_) {
delete t;
~ScopedSessionVector() {
for (SSL_SESSION *session : *sessions_) {
SSL_SESSION_free(session);
}
}
private:
std::vector<T*> *const v_;
std::vector<SSL_SESSION*> *const sessions_;
};
// Test that the internal session cache behaves as expected.
@ -901,7 +901,7 @@ static bool TestInternalSessionCache() {
// Prepare 10 test sessions.
std::vector<SSL_SESSION*> sessions;
ScopedVector<SSL_SESSION> cleanup(&sessions);
ScopedSessionVector cleanup(&sessions);
for (int i = 0; i < 10; i++) {
ScopedSSL_SESSION session = CreateTestSession(i);
if (!session) {