kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Mark OPENSSL_armcap_P as hidden in ARM asm.

Browse Source 
This is an import from ARM. Without this, one of the Android builds of
BoringSSL was failing with:
  (sha512-armv4.o): requires unsupported dynamic reloc R_ARM_REL32; recompile with -fPIC

This is (I believe) a very misleading error message. The R_ARM_REL32
relocation type is the correct type for position independent code. But
unless the target symbol is hidden then the linker doesn't know that
it's not going to be overridden by a different ELF module.

Chromium probably gets away with this because of different default
compiler flags than Android.

Change-Id: I967eabc4d6b33d1e6635caaf6e7a306e4e77c101
Reviewed-on: https://boringssl-review.googlesource.com/3471
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
Adam Langley 2015-02-13 14:57:49 -08:00
parent d3459fb2f9
commit 16e38b2b8f
4 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crypto/bn/asm/armv4-mont.pl
View File

@ -661,6 +661,7 @@ $code.=<<___;
.align 2
#if __ARM_ARCH__>=7
.comm OPENSSL_armcap_P,4,4
.hidden OPENSSL_armcap_P
#endif
___

1
crypto/sha/asm/sha1-armv4-large.pl
View File

@ -642,6 +642,7 @@ ___
$code.=<<___;
#if __ARM_MAX_ARCH__>=7
.comm OPENSSL_armcap_P,4,4
.hidden OPENSSL_armcap_P
#endif
___

1
crypto/sha/asm/sha256-armv4.pl
View File

@ -621,6 +621,7 @@ $code.=<<___;
.align 2
#if __ARM_MAX_ARCH__>=7
.comm OPENSSL_armcap_P,4,4
.hidden OPENSSL_armcap_P
#endif
___

1
crypto/sha/asm/sha512-armv4.pl
View File

@ -599,6 +599,7 @@ $code.=<<___;
.align 2
#if __ARM_MAX_ARCH__>=7
.comm OPENSSL_armcap_P,4,4
.hidden OPENSSL_armcap_P
#endif
___