Move SendV2ClientHello to handshake coverage tests.

It's a different handshake flow with more state machine coverage. We should
make sure to test the asynchronous version.

Change-Id: I0bb79ca7e6a86bd3cac66bac1f795a885d474909
Reviewed-on: https://boringssl-review.googlesource.com/1454
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2014-08-08 12:27:04 -04:00 committed by Adam Langley
parent bed9aae757
commit 1e7f8d70ec

View File

@ -349,19 +349,6 @@ var testCases = []testCase{
"-select-next-proto", "foo",
},
},
{
testType: serverTest,
name: "SendV2ClientHello",
config: Config{
// Choose a cipher suite that does not involve
// elliptic curves, so no extensions are
// involved.
CipherSuites: []uint16{TLS_RSA_WITH_RC4_128_SHA},
Bugs: ProtocolBugs{
SendV2ClientHello: true,
},
},
},
{
testType: serverTest,
name: "FallbackSCSV",
@ -1000,6 +987,23 @@ func addStateMachineCoverageTests(async bool, splitHandshake bool) {
},
flags: append(flags, "-require-any-client-certificate"),
})
// Client sends a V2ClientHello.
testCases = append(testCases, testCase{
testType: serverTest,
name: "SendV2ClientHello",
config: Config{
// Choose a cipher suite that does not involve
// elliptic curves, so no extensions are
// involved.
CipherSuites: []uint16{TLS_RSA_WITH_RC4_128_SHA},
Bugs: ProtocolBugs{
MaxHandshakeRecordLength: maxHandshakeRecordLength,
SendV2ClientHello: true,
},
},
flags: flags,
})
}
func addVersionNegotiationTests() {