kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Check BIO_flush return value.

Browse Source 
That we're ignoring the return value is clearly wrong when
dtls1_retransmit_message has other code that doesn't ignore it, by way of
dtls1_do_handshake_write.

Change-Id: Ie3f8c0defdf1f5e709d67af4ca6fa4f0d83c76c9
Reviewed-on: https://boringssl-review.googlesource.com/7872
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2016-05-05 21:17:53 -04:00 committed by Adam Langley
parent 30152fdfc1
commit 2730955e74
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ssl/d1_both.c
View File

@ -759,10 +759,11 @@ int dtls1_retransmit_buffered_messages(SSL *ssl) {
} }
} }
/* TODO(davidben): Check return value? */ ret = BIO_flush(SSL_get_wbio(ssl));
(void)BIO_flush(SSL_get_wbio(ssl)); if (ret <= 0) {
ssl->rwstate = SSL_WRITING;
ret = 1; goto err;
}
err: err:
if (!was_buffered) { if (!was_buffered) {