kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove incorrect TODO(fork).

Browse Source 
The OR seems to be correct. %r9d previously contains 1 for a non-Intel
CPU. The next line isolates the XOP bit but *also* preserves that 1.
This figures in later in in line 121 to avoid tagging as Intel. (Most
codepaths in the AMD-specific branch go straight to .Lgeneric, but some
go to .Lintel. This probably could be done more clearly as there's some
complicated code that's subtly different...)

Change-Id: Ie7b9566074498333f26416e46478e4f4df68194f
Reviewed-on: https://boringssl-review.googlesource.com/5433
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2015-07-11 14:07:14 -04:00 committed by Adam Langley
parent c3717f4a00
commit 31ac9aae51
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crypto/cpu-x86_64-asm.pl
View File

@ -70,7 +70,6 @@ OPENSSL_ia32_cpuid:
mov \$0x80000001,%eax mov \$0x80000001,%eax
cpuid cpuid
# Returns feature bits in ECX. See page 20 of [1]. # Returns feature bits in ECX. See page 20 of [1].
# TODO(fork): I think this should be a MOV.
or %ecx,%r9d or %ecx,%r9d
and \$0x00000801,%r9d # isolate AMD XOP bit, 1<<11 and \$0x00000801,%r9d # isolate AMD XOP bit, 1<<11