kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix curve25519 code for MSVC.

Browse Source 
MSVC doesn't like unary minus on unsigned types. Also, the speed test
always failed because the inputs were all zeros and thus had small
order.

Change-Id: Ic2d3c2c9bd57dc66295d93891396871cebac1e0b
This commit is contained in:
Adam Langley 2015-11-17 15:15:05 -08:00
parent 4fb0dc4b03
commit 3ac32b1eda
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/curve25519/curve25519.c
View File

@ -231,7 +231,7 @@ static void fe_1(fe h) {
*
* Preconditions: b in {0,1}. */
static void fe_cswap(fe f, fe g, unsigned int b) {
b = -b;
b = 0-b;
unsigned i;
for (i = 0; i < 10; i++) {
int32_t x = f[i] ^ g[i];
@ -807,7 +807,7 @@ static void fe_neg(fe h, const fe f) {
*
* Preconditions: b in {0,1}. */
static void fe_cmov(fe f, const fe g, unsigned b) {
b = -b;
b = 0-b;
unsigned i;
for (i = 0; i < 10; i++) {
int32_t x = f[i] ^ g[i];

2
tool/speed.cc
View File

@ -456,6 +456,8 @@ static bool Speed25519(const std::string &selected) {
uint8_t out[32], in1[32], in2[32];
memset(in1, 0, sizeof(in1));
memset(in2, 0, sizeof(in2));
in1[0] = 1;
in2[0] = 9;
return X25519(out, in1, in2) == 1;
})) {
fprintf(stderr, "Curve25519 arbitrary point multiplication failed.\n");