kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Set |bn->neg| to zero in |bn_set_words|.

Browse Source 
If the values of any of the coordinates in the output point |r| were
negative during nistz256 multiplication, then the calls to
|bn_set_word| would result in the wrong coordinates being returned
(the negatives of the correct coordinates would be returned instead).
Fix that.

Change-Id: I6048e62f76dca18f625650d11ef5a051c9e672a4
Reviewed-on: https://boringssl-review.googlesource.com/7442
Reviewed-by: David Benjamin <davidben@google.com>
This commit is contained in:
Brian Smith 2016-03-10 17:16:02 -10:00 committed by David Benjamin
parent 6603b76f76
commit 3f1904bee1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crypto/bn/bn.c
View File

@ -274,6 +274,7 @@ int bn_set_words(BIGNUM *bn, const BN_ULONG *words, size_t num) {
/* |bn_wexpand| verified that |num| isn't too large. */ /* |bn_wexpand| verified that |num| isn't too large. */
bn->top = (int)num; bn->top = (int)num;
bn_correct_top(bn); bn_correct_top(bn);
bn->neg = 0;
return 1; return 1;
} }