From 449a9e6a9e25dc871d31138e7a2ced6063878bdd Mon Sep 17 00:00:00 2001 From: Adam Langley Date: Thu, 25 Jan 2018 15:38:24 -0800 Subject: [PATCH] Make the gdb window larger. Running can spawn gdb in an xterm, but the default xterm is rather small. We could have everyone set their .Xdefaults, I presume, to solve this, but very few people are running the old xterm these days. Change-Id: I46eb3ff22f292eb44ce8c5124e83f1ab8aef9547 Reviewed-on: https://boringssl-review.googlesource.com/24846 Reviewed-by: Adam Langley Reviewed-by: David Benjamin Commit-Queue: David Benjamin CQ-Verified: CQ bot account: commit-bot@chromium.org --- ssl/test/runner/runner.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ssl/test/runner/runner.go b/ssl/test/runner/runner.go index ebe533f0..e17f5dd6 100644 --- a/ssl/test/runner/runner.go +++ b/ssl/test/runner/runner.go @@ -899,10 +899,12 @@ func doExchange(test *testCase, config *Config, conn net.Conn, isResume bool, tr return nil } +const xtermSize = "140x50" + func valgrindOf(dbAttach bool, path string, args ...string) *exec.Cmd { valgrindArgs := []string{"--error-exitcode=99", "--track-origins=yes", "--leak-check=full", "--quiet"} if dbAttach { - valgrindArgs = append(valgrindArgs, "--db-attach=yes", "--db-command=xterm -e gdb -nw %f %p") + valgrindArgs = append(valgrindArgs, "--db-attach=yes", "--db-command=xterm -geometry "+xtermSize+" -e gdb -nw %f %p") } valgrindArgs = append(valgrindArgs, path) valgrindArgs = append(valgrindArgs, args...) @@ -911,7 +913,7 @@ func valgrindOf(dbAttach bool, path string, args ...string) *exec.Cmd { } func gdbOf(path string, args ...string) *exec.Cmd { - xtermArgs := []string{"-e", "gdb", "--args"} + xtermArgs := []string{"-geometry", xtermSize, "-e", "gdb", "--args"} xtermArgs = append(xtermArgs, path) xtermArgs = append(xtermArgs, args...) @@ -919,7 +921,7 @@ func gdbOf(path string, args ...string) *exec.Cmd { } func lldbOf(path string, args ...string) *exec.Cmd { - xtermArgs := []string{"-e", "lldb", "--"} + xtermArgs := []string{"-geometry", xtermSize, "-e", "lldb", "--"} xtermArgs = append(xtermArgs, path) xtermArgs = append(xtermArgs, args...)