Import NIST ECDSA verification tests.

Change-Id: Idaec86866c600b87cda662b1b31c864cb1d141ac
Reviewed-on: https://boringssl-review.googlesource.com/10702
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

crypto/ecdsa/CMakeLists.txt

@@ -26,6 +26,15 @@ add_executable(
   $<TARGET_OBJECTS:test_support>
 )
 
+add_executable(
+  ecdsa_verify_test
+
+  ecdsa_verify_test.cc
+
+  $<TARGET_OBJECTS:test_support>
+)
+
 target_link_libraries(ecdsa_test crypto)
 target_link_libraries(ecdsa_sign_test crypto)
-add_dependencies(all_tests ecdsa_test ecdsa_sign_test)
+target_link_libraries(ecdsa_verify_test crypto)
+add_dependencies(all_tests ecdsa_test ecdsa_sign_test ecdsa_verify_test)

crypto/ecdsa/ecdsa_verify_test.cc

@@ -0,0 +1,109 @@
+/* Copyright (c) 2016, Google Inc.
+ *
+ * Permission to use, copy, modify, and/or distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
+ * SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
+ * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
+ * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */
+
+#include <stdio.h>
+
+#include <vector>
+
+#include <openssl/bn.h>
+#include <openssl/crypto.h>
+#include <openssl/ec.h>
+#include <openssl/ec_key.h>
+#include <openssl/ecdsa.h>
+
+#include "../test/file_test.h"
+#include "../test/scoped_types.h"
+
+
+static ScopedEC_GROUP GetCurve(FileTest *t, const char *key) {
+  std::string curve_name;
+  if (!t->GetAttribute(&curve_name, key)) {
+    return nullptr;
+  }
+
+  if (curve_name == "P-224") {
+    return ScopedEC_GROUP(EC_GROUP_new_by_curve_name(NID_secp224r1));
+  }
+  if (curve_name == "P-256") {
+    return ScopedEC_GROUP(EC_GROUP_new_by_curve_name(NID_X9_62_prime256v1));
+  }
+  if (curve_name == "P-384") {
+    return ScopedEC_GROUP(EC_GROUP_new_by_curve_name(NID_secp384r1));
+  }
+  if (curve_name == "P-521") {
+    return ScopedEC_GROUP(EC_GROUP_new_by_curve_name(NID_secp521r1));
+  }
+
+  t->PrintLine("Unknown curve '%s'", curve_name.c_str());
+  return nullptr;
+}
+
+static ScopedBIGNUM GetBIGNUM(FileTest *t, const char *key) {
+  std::vector<uint8_t> bytes;
+  if (!t->GetBytes(&bytes, key)) {
+    return nullptr;
+  }
+
+  return ScopedBIGNUM(BN_bin2bn(bytes.data(), bytes.size(), nullptr));
+}
+
+static bool TestECDSASign(FileTest *t, void *arg) {
+  ScopedEC_GROUP group = GetCurve(t, "Curve");
+  ScopedBIGNUM x = GetBIGNUM(t, "X");
+  ScopedBIGNUM y = GetBIGNUM(t, "Y");
+  ScopedBIGNUM r = GetBIGNUM(t, "R");
+  ScopedBIGNUM s = GetBIGNUM(t, "S");
+  std::vector<uint8_t> digest;
+  if (!group || !x || !y || !r || !s ||
+      !t->GetBytes(&digest, "Digest")) {
+    return false;
+  }
+
+  ScopedEC_KEY key(EC_KEY_new());
+  ScopedEC_POINT pub_key(EC_POINT_new(group.get()));
+  ScopedECDSA_SIG sig(ECDSA_SIG_new());
+  if (!key || !pub_key || !sig ||
+      !EC_KEY_set_group(key.get(), group.get()) ||
+      !EC_POINT_set_affine_coordinates_GFp(group.get(), pub_key.get(), x.get(),
+                                           y.get(), nullptr) ||
+      !EC_KEY_set_public_key(key.get(), pub_key.get()) ||
+      !BN_copy(sig->r, r.get()) ||
+      !BN_copy(sig->s, s.get())) {
+    return false;
+  }
+
+  int ok = ECDSA_do_verify(digest.data(), digest.size(), sig.get(), key.get());
+  if (t->HasAttribute("Invalid")) {
+    if (ok) {
+      t->PrintLine("Signature was incorrectly accepted.");
+      return false;
+    }
+  } else if (!ok) {
+    t->PrintLine("Signature was incorrectly rejected.");
+    return false;
+  }
+
+  return true;
+}
+
+int main(int argc, char *argv[]) {
+  CRYPTO_library_init();
+
+  if (argc != 2) {
+    fprintf(stderr, "%s <test file.txt>\n", argv[0]);
+    return 1;
+  }
+
+  return FileTestMain(TestECDSASign, nullptr, argv[1]);
+}

util/all_tests.json

@@ -44,6 +44,7 @@
 	["crypto/ecdh/ecdh_test", "crypto/ecdh/ecdh_tests.txt"],
 	["crypto/ecdsa/ecdsa_sign_test", "crypto/ecdsa/ecdsa_sign_tests.txt"],
 	["crypto/ecdsa/ecdsa_test"],
+	["crypto/ecdsa/ecdsa_verify_test", "crypto/ecdsa/ecdsa_verify_tests.txt"],
 	["crypto/err/err_test"],
 	["crypto/evp/evp_extra_test"],
 	["crypto/evp/evp_test", "crypto/evp/evp_tests.txt"],