From 48e2be247a02a727487b19e745fcf6c24cc8823d Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Wed, 21 Dec 2016 12:37:00 -0500 Subject: [PATCH] Include the type in empty vector literals. Chromium on Linux builds against libstdc++'s debug mode which makes clang unhappy due to: ../crypto/bytestring/bytestring_test.cc:910:7: error: chosen constructor is explicit in copy-initialization {}, ^~ /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/debug/vector:79:7: note: constructor declared here vector(const _Allocator& __a = _Allocator()) ^ I believe this was fixed here, but it's too recent: https://github.com/gcc-mirror/gcc/commit/36f540c70ba27e441bd07111a2107b8993382905 Change-Id: I2942d153e1278785c3b81294bc99b86f297cf719 Reviewed-on: https://boringssl-review.googlesource.com/12967 Reviewed-by: Adam Langley --- crypto/bytestring/bytestring_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/bytestring/bytestring_test.cc b/crypto/bytestring/bytestring_test.cc index b2b20d7d..12275d60 100644 --- a/crypto/bytestring/bytestring_test.cc +++ b/crypto/bytestring/bytestring_test.cc @@ -907,7 +907,7 @@ static bool TestBitString() { static const std::vector kInvalidBitStrings[] = { // BIT STRINGs always have a leading byte. - {}, + std::vector{}, // It's not possible to take an unused bit off the empty string. {0x01}, // There can be at most 7 unused bits.