From 592b532dda4553e2a07e5a48cf860338f66b0897 Mon Sep 17 00:00:00 2001 From: David Benjamin Date: Fri, 30 Sep 2016 15:15:01 -0400 Subject: [PATCH] Fix TLS 1.3 downgrade detection tests. They weren't updated for the new version negotiation. (Though right now they're just testing that we *don't* implement the downgrade detection because it's a draft version.) Change-Id: I4c983ebcdf3180d682833caf1e0063467ea41544 Reviewed-on: https://boringssl-review.googlesource.com/11406 Commit-Queue: David Benjamin Reviewed-by: Adam Langley --- ssl/test/runner/runner.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ssl/test/runner/runner.go b/ssl/test/runner/runner.go index f8cf6504..3c398086 100644 --- a/ssl/test/runner/runner.go +++ b/ssl/test/runner/runner.go @@ -4387,6 +4387,7 @@ func addVersionNegotiationTests() { NegotiateVersion: VersionTLS12, }, }, + expectedVersion: VersionTLS12, // TODO(davidben): This test should fail once TLS 1.3 is final // and the fallback signal restored. }) @@ -4395,9 +4396,10 @@ func addVersionNegotiationTests() { name: "Downgrade-TLS12-Server", config: Config{ Bugs: ProtocolBugs{ - SendClientVersion: VersionTLS12, + SendSupportedVersions: []uint16{VersionTLS12}, }, }, + expectedVersion: VersionTLS12, // TODO(davidben): This test should fail once TLS 1.3 is final // and the fallback signal restored. })