kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Require that FOO_free functions do nothing on NULL.

Browse Source 
This is consistent with C's free function and upstream's convention.

Change-Id: I83f6e2f5824e28f69a9916e580dc2d8cb3b94234
Reviewed-on: https://boringssl-review.googlesource.com/4512
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2015-04-22 13:38:00 -04:00 committed by Adam Langley
parent 4fcc2e2031
commit 5d1ec73b0f
4 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
STYLE
View File

@ -105,7 +105,8 @@ type.
Some types are allocated within the library while others are Some types are allocated within the library while others are
initialized into a struct allocated by the caller, often on the initialized into a struct allocated by the caller, often on the
stack. Name these functions TYPE_NAME_new/TYPE_NAME_free and stack. Name these functions TYPE_NAME_new/TYPE_NAME_free and
TYPE_NAME_init/TYPE_NAME_cleanup, respectively. TYPE_NAME_init/TYPE_NAME_cleanup, respectively. All TYPE_NAME_free
functions must do nothing on NULL input.
If a variable is the length of a pointer value, it has the suffix If a variable is the length of a pointer value, it has the suffix
_len. An output parameter is named out or has an out_ prefix. For _len. An output parameter is named out or has an out_ prefix. For

2
crypto/x509/x509_vpm.c
View File

@ -185,6 +185,8 @@ X509_VERIFY_PARAM *X509_VERIFY_PARAM_new(void)
void X509_VERIFY_PARAM_free(X509_VERIFY_PARAM *param) void X509_VERIFY_PARAM_free(X509_VERIFY_PARAM *param)
{ {
if (param == NULL)
return;
x509_verify_param_zero(param); x509_verify_param_zero(param);
OPENSSL_free(param->id); OPENSSL_free(param->id);
OPENSSL_free(param); OPENSSL_free(param);

3
ssl/d1_both.c
View File

@ -196,6 +196,9 @@ static hm_fragment *dtls1_hm_fragment_new(unsigned long frag_len,
} }
void dtls1_hm_fragment_free(hm_fragment *frag) { void dtls1_hm_fragment_free(hm_fragment *frag) {
if (frag == NULL) {
return;
}
if (frag->fragment) { if (frag->fragment) {
OPENSSL_free(frag->fragment); OPENSSL_free(frag->fragment);
} }

3
ssl/ssl_lib.c
View File

@ -460,6 +460,9 @@ int SSL_set1_param(SSL *ssl, X509_VERIFY_PARAM *vpm) {
void ssl_cipher_preference_list_free( void ssl_cipher_preference_list_free(
struct ssl_cipher_preference_list_st *cipher_list) { struct ssl_cipher_preference_list_st *cipher_list) {
if (cipher_list == NULL) {
return;
}
sk_SSL_CIPHER_free(cipher_list->ciphers); sk_SSL_CIPHER_free(cipher_list->ciphers);
OPENSSL_free(cipher_list->in_group_flags); OPENSSL_free(cipher_list->in_group_flags);
OPENSSL_free(cipher_list); OPENSSL_free(cipher_list);