kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Base64 padding fix.

Browse Source 
https://rt.openssl.org/Ticket/Display.html?id=2608

Previously, this input to the base64 code:

================================================================================-

Would cause the output length of EVP_DecodeUpdate to be negative. When
that happened in the base64 BIO, it would crash. In PEM decoding, the
ASN.1 code actually maintains signed lengths and manages to simply error
out!
This commit is contained in:
Adam Langley 2014-06-20 12:00:00 -07:00
parent c3174b7b2d
commit 64bda23cad
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crypto/base64/base64.c
View File

@ -250,6 +250,11 @@ int EVP_DecodeUpdate(EVP_ENCODE_CTX *ctx, uint8_t *out, int *out_len,
seof = n; seof = n;
} }
eof++; eof++;
if (eof > 2) {
/* There are, at most, two equals signs at the end of base64 data. */
rv = -1;
goto end;
}
} }
if (v == B64_CR) { if (v == B64_CR) {