kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sha/asm/sha1-x86_64.pl: fix crash in SHAEXT code on Windows.

Browse Source 
RT#4530

(Imported from upstream's 7123aa81e9fb19afb11fdf3850662c5f7ff1f19c.)

We've yet to enable this code, but this confirms that we do indeed need
to get our future all-variants stuff working on Windows as well as
Linux and find an AVX2-capable CI setup on each.

The crash here is caused by some win64-only code using %rax as a frame
pointer (perlasm injects a mov rax,rsp in the prologue of every win64
function).

Change-Id: Ifbe59ceb6ae29266d9cf8a461920344a32b6e555
Reviewed-on: https://boringssl-review.googlesource.com/10366
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
Commit-Queue: David Benjamin <davidben@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2016-08-16 01:54:53 -04:00 committed by CQ bot account: commit-bot@chromium.org
parent 2a795a1775
commit 722ba2db77
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/sha/asm/sha1-x86_64.pl
View File

@ -364,9 +364,9 @@ $code.=<<___;
.align 16 .align 16
.Loop_shaext: .Loop_shaext:
dec $num dec $num
lea 0x40($inp),%rax # next input block lea 0x40($inp),%r8 # next input block
paddd @MSG[0],$E paddd @MSG[0],$E
cmovne %rax,$inp cmovne %r8,$inp
movdqa $ABCD,$ABCD_SAVE # offload $ABCD movdqa $ABCD,$ABCD_SAVE # offload $ABCD
___ ___
for($i=0;$i<20-4;$i+=2) { for($i=0;$i<20-4;$i+=2) {