A bunch of dead assignments.

Caught by clang scan-build.

Change-Id: I4f10c879dc137d4a14a7a395764d28e5caa033ff
Reviewed-on: https://boringssl-review.googlesource.com/1342
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2014-07-25 03:56:20 -04:00 committed by Adam Langley
parent 072c953f40
commit 7bbeead507
4 changed files with 2 additions and 10 deletions

View File

@ -232,7 +232,6 @@ static void decode_hex(BIGNUM *bn, const char *in, int i) {
BN_ULONG l=0; BN_ULONG l=0;
j = i; /* least significant 'hex' */ j = i; /* least significant 'hex' */
m = 0;
h = 0; h = 0;
while (j > 0) { while (j > 0) {
m = ((BN_BYTES * 2) <= j) ? (BN_BYTES * 2) : j; m = ((BN_BYTES * 2) <= j) ? (BN_BYTES * 2) : j;
@ -383,7 +382,6 @@ char *BN_bn2dec(const BIGNUM *a) {
*p++ = '-'; *p++ = '-';
} }
i = 0;
while (!BN_is_zero(t)) { while (!BN_is_zero(t)) {
*lp = BN_div_word(t, BN_DEC_CONV); *lp = BN_div_word(t, BN_DEC_CONV);
lp++; lp++;

View File

@ -509,7 +509,6 @@ static int mod_exp_recp(BIGNUM *r, const BIGNUM *a, const BIGNUM *p,
* how bit a window to do. To do this we need to scan * how bit a window to do. To do this we need to scan
* forward until the last set bit before the end of the * forward until the last set bit before the end of the
* window */ * window */
j = wstart;
wvalue = 1; wvalue = 1;
wend = 0; wend = 0;
for (i = 1; i < window; i++) { for (i = 1; i < window; i++) {

View File

@ -413,7 +413,6 @@ static void DES_encrypt1(uint32_t *data, const DES_key_schedule *ks, int enc) {
FP(r, l); FP(r, l);
data[0] = l; data[0] = l;
data[1] = r; data[1] = r;
l = r = t = u = 0;
} }
static void DES_encrypt2(uint32_t *data, const DES_key_schedule *ks, int enc) { static void DES_encrypt2(uint32_t *data, const DES_key_schedule *ks, int enc) {
@ -473,7 +472,6 @@ static void DES_encrypt2(uint32_t *data, const DES_key_schedule *ks, int enc) {
/* rotate and clear the top bits on machines with 8byte longs */ /* rotate and clear the top bits on machines with 8byte longs */
data[0] = ROTATE(l, 3) & 0xffffffffL; data[0] = ROTATE(l, 3) & 0xffffffffL;
data[1] = ROTATE(r, 3) & 0xffffffffL; data[1] = ROTATE(r, 3) & 0xffffffffL;
l = r = t = u = 0;
} }
static void DES_encrypt3(uint32_t *data, const DES_key_schedule *ks1, static void DES_encrypt3(uint32_t *data, const DES_key_schedule *ks1,
@ -532,7 +530,7 @@ void DES_ecb_encrypt(const DES_cblock *in_block, DES_cblock *out_block,
l2c(l, out); l2c(l, out);
l = ll[1]; l = ll[1];
l2c(l, out); l2c(l, out);
l = ll[0] = ll[1] = 0; ll[0] = ll[1] = 0;
} }
void DES_ncbc_encrypt(const uint8_t *in, uint8_t *out, size_t len, void DES_ncbc_encrypt(const uint8_t *in, uint8_t *out, size_t len,
@ -608,7 +606,6 @@ void DES_ncbc_encrypt(const uint8_t *in, uint8_t *out, size_t len,
l2c(xor0, iv); l2c(xor0, iv);
l2c(xor1, iv); l2c(xor1, iv);
} }
tin0 = tin1 = tout0 = tout1 = xor0 = xor1 = 0;
tin[0] = tin[1] = 0; tin[0] = tin[1] = 0;
} }
@ -709,6 +706,5 @@ void DES_ede3_cbc_encrypt(const uint8_t *in, uint8_t *out, size_t len,
l2c(xor1, iv); l2c(xor1, iv);
} }
tin0 = tin1 = tout0 = tout1 = xor0 = xor1 = 0;
tin[0] = tin[1] = 0; tin[0] = tin[1] = 0;
} }

View File

@ -2701,8 +2701,7 @@ int ssl3_send_client_certificate(SSL *s)
{ {
/* If we get an error, we need to /* If we get an error, we need to
* ssl->rwstate=SSL_X509_LOOKUP; return(-1); * ssl->rwstate=SSL_X509_LOOKUP; return(-1);
* We then get retied later */ * We then get retried later */
i=0;
i = ssl_do_client_cert_cb(s, &x509, &pkey); i = ssl_do_client_cert_cb(s, &x509, &pkey);
if (i < 0) if (i < 0)
{ {