kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add the is_unexpected key to the test output.

Browse Source 
If the key is missing, it seems the failure is assumed to be expected.

BUG=473924

Change-Id: I62edd9110fa74bee5e6425fd6786badf5398728c
Reviewed-on: https://boringssl-review.googlesource.com/4231
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2015-04-04 03:57:26 -04:00 committed by Adam Langley
parent 6c2563e241
commit 7ead605599
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ssl/test/runner/test_output.go
View File

@ -32,8 +32,9 @@ type testOutput struct {
}
type testResult struct {
Actual string `json:"actual"`
Expected string `json:"expected"`
Actual string `json:"actual"`
Expected string `json:"expected"`
IsUnexpected bool `json:"is_unexpected"`
}
func newTestOutput() *testOutput {
@ -50,7 +51,11 @@ func (t *testOutput) addResult(name, result string) {
if _, found := t.Tests[name]; found {
panic(name)
}
t.Tests[name] = testResult{Actual: result, Expected: "PASS"}
t.Tests[name] = testResult{
Actual: result,
Expected: "PASS",
IsUnexpected: result != "PASS",
}
t.NumFailuresByType[result]++
}

11
util/all_tests.go
View File

@ -101,8 +101,9 @@ type testOutput struct {
}
type testResult struct {
Actual string `json:"actual"`
Expected string `json:"expected"`
Actual string `json:"actual"`
Expected string `json:"expected"`
IsUnexpected bool `json:"is_unexpected"`
}
func newTestOutput() *testOutput {
@ -119,7 +120,11 @@ func (t *testOutput) addResult(name, result string) {
if _, found := t.Tests[name]; found {
panic(name)
}
t.Tests[name] = testResult{Actual: result, Expected: "PASS"}
t.Tests[name] = testResult{
Actual: result,
Expected: "PASS",
IsUnexpected: result != "PASS",
}
t.NumFailuresByType[result]++
}