kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Include EC_POINT_oct2point in ECDH benchmarks.

Browse Source 
This includes a point validation, which figures into the overall cost of
an ECDH operation. If, say, point validation is slow because it uses
generic code, we'd like it to show up in benchmarks.

(Later I'd like to replace this mess with a simple byte-oriented ECDH
API. When that happens, I'll update the benchmark accordingly.)

Change-Id: If8c33542d4b40572aac0a71ea2f658e7bc501f4b
Reviewed-on: https://boringssl-review.googlesource.com/26969
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2018-03-31 23:56:13 -04:00 committed by Adam Langley
parent 04018c5929
commit 88b1a37e88
1 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
tool/speed.cc
View File

@ -442,8 +442,28 @@ static bool SpeedECDHCurve(const std::string &name, int nid,
return true; return true;
} }
bssl::UniquePtr<EC_KEY> peer_key(EC_KEY_new_by_curve_name(nid));
if (!peer_key ||
!EC_KEY_generate_key(peer_key.get())) {
return false;
}
size_t peer_value_len = EC_POINT_point2oct(
EC_KEY_get0_group(peer_key.get()), EC_KEY_get0_public_key(peer_key.get()),
POINT_CONVERSION_UNCOMPRESSED, nullptr, 0, nullptr);
if (peer_value_len == 0) {
return false;
}
std::unique_ptr<uint8_t[]> peer_value(new uint8_t[peer_value_len]);
peer_value_len = EC_POINT_point2oct(
EC_KEY_get0_group(peer_key.get()), EC_KEY_get0_public_key(peer_key.get()),
POINT_CONVERSION_UNCOMPRESSED, peer_value.get(), peer_value_len, nullptr);
if (peer_value_len == 0) {
return false;
}
TimeResults results; TimeResults results;
if (!TimeFunction(&results, [nid]() -> bool { if (!TimeFunction(&results, [nid, peer_value_len, &peer_value]() -> bool {
bssl::UniquePtr<EC_KEY> key(EC_KEY_new_by_curve_name(nid)); bssl::UniquePtr<EC_KEY> key(EC_KEY_new_by_curve_name(nid));
if (!key || if (!key ||
!EC_KEY_generate_key(key.get())) { !EC_KEY_generate_key(key.get())) {
@ -451,14 +471,16 @@ static bool SpeedECDHCurve(const std::string &name, int nid,
} }
const EC_GROUP *const group = EC_KEY_get0_group(key.get()); const EC_GROUP *const group = EC_KEY_get0_group(key.get());
bssl::UniquePtr<EC_POINT> point(EC_POINT_new(group)); bssl::UniquePtr<EC_POINT> point(EC_POINT_new(group));
bssl::UniquePtr<EC_POINT> peer_point(EC_POINT_new(group));
bssl::UniquePtr<BN_CTX> ctx(BN_CTX_new()); bssl::UniquePtr<BN_CTX> ctx(BN_CTX_new());
bssl::UniquePtr<BIGNUM> x(BN_new()); bssl::UniquePtr<BIGNUM> x(BN_new());
bssl::UniquePtr<BIGNUM> y(BN_new()); bssl::UniquePtr<BIGNUM> y(BN_new());
if (!point || !ctx || !x || !y || if (!point || !peer_point || !ctx || !x || !y ||
!EC_POINT_mul(group, point.get(), NULL, !EC_POINT_oct2point(group, peer_point.get(), peer_value.get(),
EC_KEY_get0_public_key(key.get()), peer_value_len, ctx.get()) ||
!EC_POINT_mul(group, point.get(), NULL, peer_point.get(),
EC_KEY_get0_private_key(key.get()), ctx.get()) || EC_KEY_get0_private_key(key.get()), ctx.get()) ||
!EC_POINT_get_affine_coordinates_GFp(group, point.get(), x.get(), !EC_POINT_get_affine_coordinates_GFp(group, point.get(), x.get(),
y.get(), ctx.get())) { y.get(), ctx.get())) {