kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix memory leak in set_signing_algorithm_prefs.

Browse Source 
If SSL_CTX_set_signing_algorithm_prefs or
SSL_set_signing_algorithm_prefs are
called multiple times for the same cert, the
previous cert->sigalgs will leak.

Free the existing sigalgs before setting a new one.

Change-Id: I73cdb366a8f47d8cc0baae986fd0aa80b60300e2
Reviewed-on: https://boringssl-review.googlesource.com/11640
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
This commit is contained in:
Daniel Bathgate 2016-10-18 14:31:02 +01:00 committed by CQ bot account: commit-bot@chromium.org
parent e228bd299d
commit 89917a5c60
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ssl/ssl_rsa.c
View File

@ -352,6 +352,8 @@ void SSL_CTX_set_private_key_method(SSL_CTX *ctx,
static int set_signing_algorithm_prefs(CERT *cert, const uint16_t *prefs, static int set_signing_algorithm_prefs(CERT *cert, const uint16_t *prefs,
size_t num_prefs) { size_t num_prefs) {
OPENSSL_free(cert->sigalgs);
cert->num_sigalgs = 0; cert->num_sigalgs = 0;
cert->sigalgs = BUF_memdup(prefs, num_prefs * sizeof(prefs[0])); cert->sigalgs = BUF_memdup(prefs, num_prefs * sizeof(prefs[0]));
if (cert->sigalgs == NULL) { if (cert->sigalgs == NULL) {