kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Increment the reference count of sessions inside the lock.

Browse Source 
Otherwise another thread may cause the session to be destroyed first.

Change-Id: I2084a28ece11540e1b8f289553161d99395e2d1f
Reviewed-on: https://boringssl-review.googlesource.com/5231
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2015-06-16 15:59:03 -04:00 committed by Adam Langley
parent d98452d2db
commit bed63548d1
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ssl/ssl_sess.c
View File

@ -420,11 +420,10 @@ int ssl_get_prev_session(SSL *s, const struct ssl_early_callback_ctx *ctx) {
CRYPTO_MUTEX_lock_read(&s->initial_ctx->lock); CRYPTO_MUTEX_lock_read(&s->initial_ctx->lock);
ret = lh_SSL_SESSION_retrieve(s->initial_ctx->sessions, &data); ret = lh_SSL_SESSION_retrieve(s->initial_ctx->sessions, &data);
CRYPTO_MUTEX_unlock(&s->initial_ctx->lock);
if (ret != NULL) { if (ret != NULL) {
SSL_SESSION_up_ref(ret); SSL_SESSION_up_ref(ret);
} }
CRYPTO_MUTEX_unlock(&s->initial_ctx->lock);
} }
if (try_session_cache && ret == NULL && if (try_session_cache && ret == NULL &&