Fix error handling in bn_exp

In the event of an error |rr| could be NULL. Therefore don't assume you can
use |rr| in the error handling code.

(Imported from upstream's 8c5a7b33c6269c3bd6bc0df6b4c22e4fba03b485.)

Change-Id: I0b392991ce8170dc418e93003af256d535d1e2e8
Reviewed-on: https://boringssl-review.googlesource.com/4005
Reviewed-by: Adam Langley <agl@google.com>
This commit is contained in:
David Benjamin 2015-03-18 19:51:13 -04:00 committed by Adam Langley
parent 87b2a13a86
commit c02f148fa8

View File

@ -172,12 +172,13 @@ int BN_exp(BIGNUM *r, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx) {
} }
} }
} }
ret = 1;
err:
if (r != rr) { if (r != rr) {
BN_copy(r, rr); BN_copy(r, rr);
} }
ret = 1;
err:
BN_CTX_end(ctx); BN_CTX_end(ctx);
return ret; return ret;
} }