kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix format-string error in delocate.go.

Browse Source 
Errorf treats its argument as a format string and so “%rax” is a
problem.

Change-Id: I863ef361f07d0b8a348994efe45869202d0b31f1
Reviewed-on: https://boringssl-review.googlesource.com/24944
Reviewed-by: Steven Valdez <svaldez@google.com>
Commit-Queue: Steven Valdez <svaldez@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
This commit is contained in:
Adam Langley 2018-01-17 15:22:51 -08:00 committed by CQ bot account: commit-bot@chromium.org
parent 37c6eb4284
commit c7ef069ac9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/fipstools/delocate.go
View File

@ -1038,7 +1038,7 @@ Args:
targetReg = d.contents(argNodes[1]) targetReg = d.contents(argNodes[1])
wrappers = append(wrappers, finalTransform(d.output, instructionName, targetReg)) wrappers = append(wrappers, finalTransform(d.output, instructionName, targetReg))
if isValidLEATarget(targetReg) { if isValidLEATarget(targetReg) {
return nil, fmt.Errorf("Currently transforming moves are assumed to target XMM registers. Otherwise we'll pop %rax before reading it to do the transform.") return nil, errors.New("Currently transforming moves are assumed to target XMM registers. Otherwise we'll pop %rax before reading it to do the transform.")
} }
default: default:
return nil, fmt.Errorf("Cannot rewrite GOTPCREL reference for instruction %q", instructionName) return nil, fmt.Errorf("Cannot rewrite GOTPCREL reference for instruction %q", instructionName)