瀏覽代碼

Add a TODO for why init_buf isn't released post-handshake.

There is no good reason why this needs to be this way. Later work should make
this all use a much more appropriate design. In the meantime, leave a note here
so this does not look accidental.

Change-Id: I7599dea7a474f54e26d9ab175b0e3cada99a974d
Reviewed-on: https://boringssl-review.googlesource.com/7951
Reviewed-by: Adam Langley <agl@google.com>
kris/onging/CECPQ3_patch15
David Benjamin 8 年之前
committed by Adam Langley
父節點
當前提交
fce37b0deb
共有 2 個文件被更改,包括 8 次插入0 次删除
  1. +4
    -0
      ssl/d1_clnt.c
  2. +4
    -0
      ssl/d1_srvr.c

+ 4
- 0
ssl/d1_clnt.c 查看文件

@@ -430,6 +430,10 @@ int dtls1_connect(SSL *ssl) {
/* Remove write buffering now. */
ssl_free_wbio_buffer(ssl);

/* |init_buf| cannot be released because post-handshake retransmit
* relies on that buffer being available as scratch space.
*
* TODO(davidben): Fix this. */
ssl->init_num = 0;
ssl->s3->initial_handshake_complete = 1;



+ 4
- 0
ssl/d1_srvr.c 查看文件

@@ -404,6 +404,10 @@ int dtls1_accept(SSL *ssl) {
/* remove buffering on output */
ssl_free_wbio_buffer(ssl);

/* |init_buf| cannot be released because post-handshake retransmit
* relies on that buffer being available as scratch space.
*
* TODO(davidben): Fix this. */
ssl->init_num = 0;
ssl->s3->initial_handshake_complete = 1;



Loading…
取消
儲存