boringssl/ssl
David Benjamin dd6fed9704 Explicitly handle empty NewSessionTickets on the client.
RFC 5077 explicitly allows the server to change its mind and send no
ticket by sending an empty NewSessionTicket. See also upstream's
21b538d616b388fa0ce64ef54da3504253895cf8.

CBS_stow handles this case somewhat, so we won't get confused about
malloc(0) as upstream did. But we'll still fill in a bogus SHA-256
session ID, cache the session, and send a ClientHello with bogus session
ID but empty ticket extension. (The session ID field changes meaning
significantly when the ticket is or isn't empty. Non-empty means "ignore
the session ID, but echo if it resuming" while empty means "I support
tickets, but am offering this session ID".

The other behavior change is that a server which changes its mind on a
resumption handshake will no longer override the client's session cache
with a ticket-less session.

(This is kind of silly. Given that we don't get completely confused due
to CBS_stow, it might not be worth bothering with the rest. Mostly it
bugged me that we send an indicator session ID with no ticket.)

Change-Id: Id6b5bde1fe51aa3e1f453a948e59bfd1e2502db6
Reviewed-on: https://boringssl-review.googlesource.com/6340
Reviewed-by: Adam Langley <alangley@gmail.com>
2015-10-26 17:44:54 +00:00
..
pqueue Fix some malloc test crashs. 2015-05-21 18:00:10 +00:00
test Explicitly handle empty NewSessionTickets on the client. 2015-10-26 17:44:54 +00:00
CMakeLists.txt Remove SSL_SESSION_print*. 2015-10-13 19:24:14 +00:00
custom_extensions.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
d1_both.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
d1_clnt.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
d1_lib.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
d1_meth.c Ditch remaining filename comments from public headers and ssl/ 2015-10-20 18:40:05 +00:00
d1_pkt.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
d1_srtp.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
d1_srvr.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
dtls_record.c Reject empty records of unexpected type. 2015-08-28 22:03:00 +00:00
internal.h Convert ssl3_send_channel_id to CBB. 2015-10-20 18:16:46 +00:00
s3_both.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
s3_clnt.c Explicitly handle empty NewSessionTickets on the client. 2015-10-26 17:44:54 +00:00
s3_enc.c Change some "int" variables to "size_t" in ssl3_handshake_mac(). 2015-09-24 00:04:59 +00:00
s3_lib.c Convert ssl3_send_channel_id to CBB. 2015-10-20 18:16:46 +00:00
s3_meth.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
s3_pkt.c Add SSL_set_renegotiate_mode. 2015-10-13 18:02:28 +00:00
s3_srvr.c Add use counters for SSL_OP_TLS_D5_BUG and SSL_OP_MICROSOFT_BIG_SSLV3_BUFFER. 2015-10-20 18:22:47 +00:00
ssl_aead_ctx.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
ssl_asn1.c Unexport SSL_SESSION_ASN1_VERSION. 2015-10-20 18:41:08 +00:00
ssl_buffer.c Fix buffer size computation. 2015-09-01 20:18:21 +00:00
ssl_cert.c Document certificate verification functions in SSL. 2015-09-23 23:31:18 +00:00
ssl_cipher.c Upstream Android-specific things under |BORINGSSL_ANDROID_SYSTEM| 2015-09-23 16:41:33 -07:00
ssl_file.c Document certificate verification functions in SSL. 2015-09-23 23:31:18 +00:00
ssl_lib.c Move remaining functions out of tls1.h. 2015-10-26 17:38:40 +00:00
ssl_rsa.c Adding more options for signing digest fallback. 2015-09-23 21:55:01 +00:00
ssl_session.c Better document the callbacks around client certificates. 2015-10-13 18:18:40 +00:00
ssl_stat.c Document alert handling. 2015-10-20 19:03:24 +00:00
ssl_test.cc Make SSL_get_client_CA_list slightly more OpenSSL-compatible. 2015-09-11 22:30:55 +00:00
t1_enc.c Align the SSL stack on #include style. 2015-09-15 23:32:07 +00:00
t1_lib.c Update references to the padding draft. 2015-10-21 14:49:23 -07:00
tls_record.c Add use counters for SSL_OP_TLS_D5_BUG and SSL_OP_MICROSOFT_BIG_SSLV3_BUFFER. 2015-10-20 18:22:47 +00:00