boringssl

Verlauf

David Benjamin 104306f587 Remove STRICT_ALIGNMENT code from modes. STRICT_ALIGNMENT is a remnant of OpenSSL code would cast pointers to size_t* and load more than one byte at a time. Not all architectures support unaligned access, so it did an alignment check and only enterred this path if aligned or the underlying architecture didn't care. This is UB. Unaligned casts in C are undefined on all architectures, so we switch these to memcpy some time ago. Compilers can optimize memcpy to the unaligned accesses we wanted. That left our modes logic as: - If STRICT_ALIGNMENT is 1 and things are unaligned, work byte-by-byte. - Otherwise, use the memcpy-based word-by-word code, which now works independent of STRICT_ALIGNMENT. Remove the first check to simplify things. On x86, x86_64, and aarch64, STRICT_ALIGNMENT is zero and this is a no-op. ARM is more complex. Per [0], ARMv7 and up support unaligned access. ARMv5 do not. ARMv6 does, but can run in a mode where it looks more like ARMv5. For ARMv7 and up, STRICT_ALIGNMENT should have been zero, but was one. Thus this change should be an improvement for ARMv7 (right now unaligned inputs lose bsaes-armv7). The Android NDK does not even support the pre-ARMv7 ABI anymore[1]. Nonetheless, Cronet still supports ARMv6 as a library. It builds with -march=armv6 which GCC interprets as supporting unaligned access, so it too did not want this code. For completeness, should anyone still care about ARMv5 or be building with an overly permissive -march flag, GCC does appear unable to inline the memcpy calls. However, GCC also does not interpret (uintptr_t)ptr % sizeof(size_t) as an alignment assertion, so such consumers have already been paying for the memcpy here and throughout the library. In general, C's arcane pointer rules mean we must resort to memcpy often, so, realistically, we must require that the compiler optimize memcpy well. [0] https://medium.com/@iLevex/the-curious-case-of-unaligned-access-on-arm-5dd0ebe24965 [1] https://developer.android.com/ndk/guides/abis#armeabi Change-Id: I3c7dea562adaeb663032e395499e69530dd8e145 Reviewed-on: https://boringssl-review.googlesource.com/c/34873 Reviewed-by: Adam Langley <agl@google.com>		vor 5 Jahren
..
asn1	Modernize OPENSSL_COMPILE_ASSERT, part 2.	vor 6 Jahren
base64	Modernize OPENSSL_COMPILE_ASSERT, part 2.	vor 6 Jahren
bio	Fix d2i_*_bio on partial reads.	vor 5 Jahren
bn_extra	Add some Node compatibility functions.	vor 5 Jahren
buf	Flatten most of the crypto target.	vor 6 Jahren
bytestring	Speculatively remove __STDC_*_MACROS.	vor 6 Jahren
chacha	Add ABI tests for ChaCha20_ctr32.	vor 5 Jahren
cipher_extra	sync EVP_get_cipherbyname with EVP_do_all_sorted	vor 5 Jahren
cmac	Flatten most of the crypto target.	vor 6 Jahren
conf	Use proper functions for lh_*.	vor 6 Jahren
curve25519	Automatically disable assembly with MSAN.	vor 6 Jahren
dh	Flatten most of the crypto target.	vor 6 Jahren
digest_extra	Fix undefined pointer casts in SHA-512 code.	vor 5 Jahren
dsa	Tidy up dsa_sign_setup.	vor 6 Jahren
ec_extra	Use EC_RAW_POINT in ECDSA.	vor 6 Jahren
ecdh_extra	Clean up EC_POINT to byte conversions.	vor 6 Jahren
ecdsa_extra	Remove unreachable code.	vor 6 Jahren
engine	Flatten most of the crypto target.	vor 6 Jahren
err	Enforce key usage for RSA keys in TLS 1.2.	vor 5 Jahren
evp	Add a very roundabout EC keygen API.	vor 5 Jahren
fipsmodule	Remove STRICT_ALIGNMENT code from modes.	vor 5 Jahren
hkdf	Flatten most of the crypto target.	vor 6 Jahren
hmac_extra	Convert a number of tests to GTest.	vor 7 Jahren
hrss	HRSS: flatten sample distribution.	vor 5 Jahren
lhash	Fix undefined function pointer casts in LHASH.	vor 6 Jahren
obj	Add initial HRSS support.	vor 5 Jahren
pem	Rewrite PEM_X509_INFO_read_bio.	vor 6 Jahren
perlasm	Tolerate spaces when parsing .type directives.	vor 5 Jahren
pkcs7	Fix undefined function pointer casts in {d2i,i2d}_Foo_{bio,fp}	vor 6 Jahren
pkcs8	Fix undefined function pointer casts in {d2i,i2d}_Foo_{bio,fp}	vor 6 Jahren
poly1305	Automatically disable assembly with MSAN.	vor 6 Jahren
pool	Use proper functions for lh_*.	vor 6 Jahren
rand_extra	Unwind RDRAND functions correctly on Windows.	vor 5 Jahren
rc4	Flatten most of the crypto target.	vor 6 Jahren
rsa_extra	Rename OPENSSL_NO_THREADS, part 1.	vor 6 Jahren
stack	Don't pass NULL,0 to qsort.	vor 5 Jahren
test	Use Windows symbol APIs in the unwind tester.	vor 5 Jahren
x509	Fix d2i_*_bio on partial reads.	vor 5 Jahren
x509v3	Unexport and rename hex_to_string, string_to_hex, and name_cmp.	vor 5 Jahren
CMakeLists.txt	Implement ABI testing for aarch64.	vor 5 Jahren
abi_self_test.cc	Use Windows symbol APIs in the unwind tester.	vor 5 Jahren
compiler_test.cc	Test that nullptr has the obvious memory representation.	vor 7 Jahren
constant_time_test.cc	Add a test for CRYPTO_memcmp.	vor 6 Jahren
cpu-aarch64-fuchsia.c	Add cpu-aarch64-fuchsia.c	vor 6 Jahren
cpu-aarch64-linux.c	Add cpu-aarch64-fuchsia.c	vor 6 Jahren
cpu-arm-linux.c	Move ARM cpuinfo functions to the header.	vor 6 Jahren
cpu-arm-linux.h	Move ARM cpuinfo functions to the header.	vor 6 Jahren
cpu-arm-linux_test.cc	Move ARM cpuinfo functions to the header.	vor 6 Jahren
cpu-arm.c	Rewrite ARM feature detection.	vor 8 Jahren
cpu-intel.c	Pretend AMD XOP was never a thing.	vor 5 Jahren
cpu-ppc64le.c	Run the comment converter on libcrypto.	vor 7 Jahren
crypto.c	Add test of assembly code dispatch.	vor 5 Jahren
ex_data.c	Unexport more of lhash.	vor 7 Jahren
impl_dispatch_test.cc	Add test of assembly code dispatch.	vor 5 Jahren
internal.h	Fix header file for _byteswap_ulong and _byteswap_uint64 from MSVC CRT	vor 5 Jahren
mem.c	Use sdallocx, if available, when deallocating.	vor 6 Jahren
refcount_c11.c	Run the comment converter on libcrypto.	vor 7 Jahren
refcount_lock.c	Modernize OPENSSL_COMPILE_ASSERT, part 2.	vor 6 Jahren
refcount_test.cc	Rename OPENSSL_NO_THREADS, part 1.	vor 6 Jahren
self_test.cc	Extract FIPS KAT tests into a function.	vor 6 Jahren
thread.c	Remove a bunch of unnecessary includes.	vor 8 Jahren
thread_none.c	Rename OPENSSL_NO_THREADS, part 1.	vor 6 Jahren
thread_pthread.c	Modernize OPENSSL_COMPILE_ASSERT, part 2.	vor 6 Jahren
thread_test.cc	Rename OPENSSL_NO_THREADS, part 1.	vor 6 Jahren
thread_win.c	Replace the last CRITICAL_SECTION with SRWLOCK.	vor 5 Jahren