David Benjamin 104306f587 Remove STRICT_ALIGNMENT code from modes. STRICT_ALIGNMENT is a remnant of OpenSSL code would cast pointers to size_t* and load more than one byte at a time. Not all architectures support unaligned access, so it did an alignment check and only enterred this path if aligned or the underlying architecture didn't care. This is UB. Unaligned casts in C are undefined on all architectures, so we switch these to memcpy some time ago. Compilers can optimize memcpy to the unaligned accesses we wanted. That left our modes logic as: - If STRICT_ALIGNMENT is 1 and things are unaligned, work byte-by-byte. - Otherwise, use the memcpy-based word-by-word code, which now works independent of STRICT_ALIGNMENT. Remove the first check to simplify things. On x86, x86_64, and aarch64, STRICT_ALIGNMENT is zero and this is a no-op. ARM is more complex. Per [0], ARMv7 and up support unaligned access. ARMv5 do not. ARMv6 does, but can run in a mode where it looks more like ARMv5. For ARMv7 and up, STRICT_ALIGNMENT should have been zero, but was one. Thus this change should be an improvement for ARMv7 (right now unaligned inputs lose bsaes-armv7). The Android NDK does not even support the pre-ARMv7 ABI anymore[1]. Nonetheless, Cronet still supports ARMv6 as a library. It builds with -march=armv6 which GCC interprets as supporting unaligned access, so it too did not want this code. For completeness, should anyone still care about ARMv5 or be building with an overly permissive -march flag, GCC does appear unable to inline the memcpy calls. However, GCC also does not interpret (uintptr_t)ptr % sizeof(size_t) as an alignment assertion, so such consumers have already been paying for the memcpy here and throughout the library. In general, C's arcane pointer rules mean we must resort to memcpy often, so, realistically, we must require that the compiler optimize memcpy well. [0] https://medium.com/@iLevex/the-curious-case-of-unaligned-access-on-arm-5dd0ebe24965 [1] https://developer.android.com/ndk/guides/abis#armeabi Change-Id: I3c7dea562adaeb663032e395499e69530dd8e145 Reviewed-on: https://boringssl-review.googlesource.com/c/34873 Reviewed-by: Adam Langley <agl@google.com>		5 jaren geleden
.github	Add a PULL_REQUEST_TEMPLATE.	8 jaren geleden
crypto	Remove STRICT_ALIGNMENT code from modes.	5 jaren geleden
decrepit	Remove non-STRICT_ALIGNMENT code from xts.c.	5 jaren geleden
fipstools	Add a CFI tester to CHECK_ABI.	5 jaren geleden
fuzz	Refresh fuzzer corpus.	5 jaren geleden
include/openssl	Update delegated credentials to draft-03	5 jaren geleden
ssl	Update delegated credentials to draft-03	5 jaren geleden
third_party	Fix signed left-shifts in curve25519.c.	5 jaren geleden
tool	Delete the variants/draft code.	5 jaren geleden
util	Move aes_nohw, bsaes, and vpaes prototypes to aes/internal.h.	5 jaren geleden
.clang-format	Import `newhope' (post-quantum key exchange).	8 jaren geleden
.gitignore	Update SDE and add the Windows version.	5 jaren geleden
API-CONVENTIONS.md	Clarify "reference" and fix typo.	6 jaren geleden
BREAKING-CHANGES.md	Add some notes on how to handle breaking changes.	6 jaren geleden
BUILDING.md	Add instructions for debugging on Android with gdb.	5 jaren geleden
CMakeLists.txt	Add a RelWithAsserts build configuration.	5 jaren geleden
CONTRIBUTING.md	Add a CONTRIBUTING.md file.	8 jaren geleden
FUZZING.md	Switch to Clang 6.0's fuzzer support.	6 jaren geleden
INCORPORATING.md	Update URL for GN quick start guide.	6 jaren geleden
LICENSE	Note licenses for support code in the top-level LICENSE file.	6 jaren geleden
PORTING.md	Remove reference to SSL3 in PORTING.md.	6 jaren geleden
README.md	Add some notes on how to handle breaking changes.	6 jaren geleden
STYLE.md	Fix some style guide samples.	7 jaren geleden
codereview.settings	Comment change in codereview.settings	6 jaren geleden
go.mod	Set up Go modules.	6 jaren geleden
sources.cmake	Add new curve/hash ECDSA combinations from Wycheproof.	6 jaren geleden

README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google’s needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don’t recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google’s product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it’s not part of the NDK) and a number of other apps/programs.

There are other files in this directory which might be helpful:

PORTING.md: how to port OpenSSL-using code to BoringSSL.
BUILDING.md: how to build BoringSSL
INCORPORATING.md: how to incorporate BoringSSL into a project.
API-CONVENTIONS.md: general API conventions for BoringSSL consumers and developers.
STYLE.md: rules and guidelines for coding style.
include/openssl: public headers with API documentation in comments. Also available online.
FUZZING.md: information about fuzzing BoringSSL.
CONTRIBUTING.md: how to contribute to BoringSSL.
BREAKING-CHANGES.md: notes on potentially-breaking changes.