123db57009
The distinction for full handshakes is not meaningful (the timestamp is currently the start of the handshake), but for renewed sessions, we currently retain the timestamp of the original issuance. Instead, when minting or receiving tickets, adjust session->time and session->timeout so that session->time is the ticket issuance time. This is still not our final TLS 1.3 behavior (which will need a both renewable and non-renewable times to honor the server ticket lifetime), but it gets us closer and unblocks handling ticket_age_add from TLS 1.3 draft 18 and sends the correct NewSessionTicket lifetime. This fixes the ticket lifetime hint which we emit on the server to mirror the true ticket lifetime. It also fixes the TLS 1.3 server code to not set the ticket lifetime hint. There is no need to waste ticket size with it, it is no longer a "hint" in TLS 1.3, and even in the TLS 1.3 code we didn't fill it in on the server. Change-Id: I140541f1005a24e53e1b1eaa90996d6dada1c3a1 Reviewed-on: https://boringssl-review.googlesource.com/12105 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: Adam Langley <agl@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> |
||
|---|---|---|
| .. | ||
| test | ||
| CMakeLists.txt | ||
| custom_extensions.c | ||
| d1_both.c | ||
| d1_lib.c | ||
| d1_pkt.c | ||
| d1_srtp.c | ||
| dtls_method.c | ||
| dtls_record.c | ||
| handshake_client.c | ||
| handshake_server.c | ||
| internal.h | ||
| s3_both.c | ||
| s3_enc.c | ||
| s3_lib.c | ||
| s3_pkt.c | ||
| ssl_aead_ctx.c | ||
| ssl_asn1.c | ||
| ssl_buffer.c | ||
| ssl_cert.c | ||
| ssl_cipher.c | ||
| ssl_ecdh.c | ||
| ssl_file.c | ||
| ssl_lib.c | ||
| ssl_rsa.c | ||
| ssl_session.c | ||
| ssl_stat.c | ||
| ssl_test.cc | ||
| t1_enc.c | ||
| t1_lib.c | ||
| tls13_both.c | ||
| tls13_client.c | ||
| tls13_enc.c | ||
| tls13_server.c | ||
| tls_method.c | ||
| tls_record.c | ||