163c95691a
Changing parameters on renegotiation makes all our APIs confusing. This one has no reason to change, so lock it down. In particular, our preference to forbid Token Binding + renego may be overridden at the IETF, even though it's insane. Loosening it will be a bit less of a headache if EMS can't change. https://www.ietf.org/mail-archive/web/unbearable/current/msg00690.html claims that this is already in the specification and enforced by NSS. I can't find anything to this effect in the specification. It just says the client MUST disable renegotiation when EMS is missing, which is wishful thinking. At a glance, NSS doesn't seem to check, though I could be misunderstanding the code. Nonetheless, locking this down is a good idea anyway. Accurate or not, take the email as an implicit endorsement of this from Mozilla. Change-Id: I236b05991d28bed199763dcf2f47bbfb9d0322d7 Reviewed-on: https://boringssl-review.googlesource.com/10721 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: Adam Langley <agl@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> |
||
|---|---|---|
| .. | ||
| runner | ||
| async_bio.cc | ||
| async_bio.h | ||
| bssl_shim.cc | ||
| CMakeLists.txt | ||
| packeted_bio.cc | ||
| packeted_bio.h | ||
| PORTING.md | ||
| README.md | ||
| scoped_types.h | ||
| test_config.cc | ||
| test_config.h | ||
BoringSSL SSL Tests
This directory contains BoringSSL's protocol-level test suite.
Testing a TLS implementation can be difficult. We need to produce invalid but sufficiently correct handshakes to get our implementation close to its edge cases. TLS's cryptographic steps mean we cannot use a transcript and effectively need a TLS implementation on the other end. But we do not wish to litter BoringSSL with options for bugs to test against.
Instead, we use a fork of the Go crypto/tls package, heavily patched with
configurable bugs. This code, along with a test suite and harness written in Go,
lives in the runner directory. The harness runs BoringSSL via a C/C++ shim
binary which lives in this directory. All communication with the shim binary
occurs with command-line flags, sockets, and standard I/O.
This strategy also ensures we always test against a second implementation. All features should be implemented twice, once in C for BoringSSL and once in Go for testing. If possible, the Go code should be suitable for potentially upstreaming. However, sometimes test code has different needs. For example, our test DTLS code enforces strict ordering on sequence numbers and has controlled packet drop simulation.
To run the tests manually, run go test from the runner directory. It takes
command-line flags found at the top of runner/runner.go. The -help option
also works after using go test -c to make a runner.test binary first.
If adding a new test, these files may be a good starting point:
runner/runner.go: the test harness and all the individual tests.runner/common.go: contains theConfigandProtocolBugsstruct which control the Go TLS implementation's behavior.test_config.h,test_config.cc: the command-line flags which control the shim's behavior.bssl_shim.cc: the shim binary itself.
For porting the test suite to a different implementation see PORTING.md.