80aa694975
This is consistent with the old behavior of d2i_*_fp and avoids tripping Conscrypt's unnecessarily fragile error-handling (see https://github.com/google/conscrypt/pull/552). Additionally, by source inspection, CPython expects ASN1_R_HEADER_TOO_LONG on EOF, analogously to PEM_R_NO_START_LINE. Fix that. The other errors are a bit haphazard in the old implementation (that code is really hard to follow), so I didn't match it too carefully. In particular, OpenSSL would report ASN1_R_HEADER_TOO_LONG on some generic tag parsing, but that is inconsistent with ASN1_R_HEADER_TOO_LONG being an EOF signal. Update-Note: https://boringssl-review.googlesource.com/32106 may have caused some compatibility issues. This should fix it. Change-Id: Idfe2746ffd7733de4338e14c58a40753e98a791e Reviewed-on: https://boringssl-review.googlesource.com/c/32444 Reviewed-by: Steven Valdez <svaldez@google.com> Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> |
||
|---|---|---|
| .. | ||
| a_digest.c | ||
| a_sign.c | ||
| a_strex.c | ||
| a_verify.c | ||
| algorithm.c | ||
| asn1_gen.c | ||
| by_dir.c | ||
| by_file.c | ||
| charmap.h | ||
| i2d_pr.c | ||
| internal.h | ||
| make_many_constraints.go | ||
| many_constraints.pem | ||
| many_names1.pem | ||
| many_names2.pem | ||
| many_names3.pem | ||
| rsa_pss.c | ||
| some_names1.pem | ||
| some_names2.pem | ||
| some_names3.pem | ||
| t_crl.c | ||
| t_req.c | ||
| t_x509.c | ||
| t_x509a.c | ||
| vpm_int.h | ||
| x509_att.c | ||
| x509_cmp.c | ||
| x509_d2.c | ||
| x509_def.c | ||
| x509_ext.c | ||
| x509_lu.c | ||
| x509_obj.c | ||
| x509_r2x.c | ||
| x509_req.c | ||
| x509_set.c | ||
| x509_test.cc | ||
| x509_time_test.cc | ||
| x509_trs.c | ||
| x509_txt.c | ||
| x509_v3.c | ||
| x509_vfy.c | ||
| x509_vpm.c | ||
| x509.c | ||
| x509cset.c | ||
| x509name.c | ||
| x509rset.c | ||
| x509spki.c | ||
| x_algor.c | ||
| x_all.c | ||
| x_attrib.c | ||
| x_crl.c | ||
| x_exten.c | ||
| x_info.c | ||
| x_name.c | ||
| x_pkey.c | ||
| x_pubkey.c | ||
| x_req.c | ||
| x_sig.c | ||
| x_spki.c | ||
| x_val.c | ||
| x_x509.c | ||
| x_x509a.c | ||