2908dd141f
bssl::UniquePtr and FOO_up_ref do not play well together. Add a helper
to simplify this. This allows us to write things like:
foo->cert = UpRef(bar->cert);
instead of:
if (bar->cert) {
X509_up_ref(bar->cert.get());
}
foo->cert.reset(bar->cert.get());
This also plays well with PushToStack. To append something to a stack
while taking a reference, it's just:
PushToStack(certs, UpRef(cert))
Change-Id: I99ae8de22b837588a2d8ffb58f86edc1d03ed46a
Reviewed-on: https://boringssl-review.googlesource.com/29584
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>
58 lines
1.9 KiB
C++
58 lines
1.9 KiB
C++
/* Copyright (c) 2016, Google Inc.
|
|
*
|
|
* Permission to use, copy, modify, and/or distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
|
|
* SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
|
|
* OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
|
|
* CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <openssl/pool.h>
|
|
|
|
#include "../test/test_util.h"
|
|
|
|
|
|
TEST(PoolTest, Unpooled) {
|
|
static const uint8_t kData[4] = {1, 2, 3, 4};
|
|
bssl::UniquePtr<CRYPTO_BUFFER> buf(
|
|
CRYPTO_BUFFER_new(kData, sizeof(kData), nullptr));
|
|
ASSERT_TRUE(buf);
|
|
|
|
EXPECT_EQ(Bytes(kData),
|
|
Bytes(CRYPTO_BUFFER_data(buf.get()), CRYPTO_BUFFER_len(buf.get())));
|
|
|
|
// Test that reference-counting works properly.
|
|
bssl::UniquePtr<CRYPTO_BUFFER> buf2 = bssl::UpRef(buf);
|
|
}
|
|
|
|
TEST(PoolTest, Empty) {
|
|
bssl::UniquePtr<CRYPTO_BUFFER> buf(CRYPTO_BUFFER_new(nullptr, 0, nullptr));
|
|
ASSERT_TRUE(buf);
|
|
|
|
EXPECT_EQ(Bytes(""),
|
|
Bytes(CRYPTO_BUFFER_data(buf.get()), CRYPTO_BUFFER_len(buf.get())));
|
|
}
|
|
|
|
TEST(PoolTest, Pooled) {
|
|
bssl::UniquePtr<CRYPTO_BUFFER_POOL> pool(CRYPTO_BUFFER_POOL_new());
|
|
ASSERT_TRUE(pool);
|
|
|
|
static const uint8_t kData[4] = {1, 2, 3, 4};
|
|
bssl::UniquePtr<CRYPTO_BUFFER> buf(
|
|
CRYPTO_BUFFER_new(kData, sizeof(kData), pool.get()));
|
|
ASSERT_TRUE(buf);
|
|
|
|
bssl::UniquePtr<CRYPTO_BUFFER> buf2(
|
|
CRYPTO_BUFFER_new(kData, sizeof(kData), pool.get()));
|
|
ASSERT_TRUE(buf2);
|
|
|
|
EXPECT_EQ(buf.get(), buf2.get()) << "CRYPTO_BUFFER_POOL did not dedup data.";
|
|
}
|