95695c8d88
This is consistent with ignoring writeRecord failures. Without doing this, the DTLS MinimumVersion test now flakily fails with: FAILED (MinimumVersion-Client-TLS12-TLS1-DTLS) bad error (wanted ':UNSUPPORTED_PROTOCOL:' / 'remote error: protocol version not supported'): local error 'write unix @: broken pipe', child error 'exit status 2', stdout: 2092242157:error:1007b1a7:SSL routines:ssl3_get_server_hello:UNSUPPORTED_PROTOCOL:../ssl/s3_clnt.c:783: This is because the MinimumVersion tests assert on /both/ expectedError and expectedLocalError. The latter is valuable as it asserts on the alert the peer returned. (I would like us to add more such assertions to our tests where appropriate.) However, after we send ServerHello, we also send a few messages following it. This races with the peer shutdown and we sometimes get EPIPE before reading the alert. Change-Id: I3fe37940a6a531379673a00976035f8e76e0f825 Reviewed-on: https://boringssl-review.googlesource.com/3337 Reviewed-by: Adam Langley <agl@google.com> |
||
|---|---|---|
| .. | ||
| alert.go | ||
| cert.pem | ||
| channel_id_key.pem | ||
| cipher_suites.go | ||
| common.go | ||
| conn.go | ||
| dtls.go | ||
| ecdsa_cert.pem | ||
| ecdsa_key.pem | ||
| handshake_client.go | ||
| handshake_messages.go | ||
| handshake_server.go | ||
| key_agreement.go | ||
| key.pem | ||
| packet_adapter.go | ||
| prf.go | ||
| recordingconn.go | ||
| runner.go | ||
| ticket.go | ||
| tls.go | ||