kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
2dc0204603
boringssl/tool
History
David Benjamin 2dc0204603 Don't return invalid versions in version_from_wire. 
This is in preparation for using the supported_versions extension to
experiment with draft TLS 1.3 versions, since we don't wish to restore
the fallback. With versions begin opaque values, we will want
version_from_wire to reject unknown values, not attempt to preserve
order in some way.

This means ClientHello.version processing needs to be separate code.
That's just written out fully in negotiate_version now. It also means
SSL_set_{min,max}_version will notice invalid inputs which aligns us
better with upstream's versions of those APIs.

This CL doesn't replace ssl->version with an internal-representation
version, though follow work should do it once a couple of changes land
in consumers.

BUG=90

Change-Id: Id2f5e1fa72847c823ee7f082e9e69f55e51ce9da
Reviewed-on: https://boringssl-review.googlesource.com/11122
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2016-09-21 19:51:45 +00:00
..
args.cc Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
ciphers.cc Replace Scoped* heap types with bssl::UniquePtr. 2016-09-01 22:22:54 +00:00
client.cc Don't return invalid versions in version_from_wire. 2016-09-21 19:51:45 +00:00
CMakeLists.txt Add a tool to generate Ed25519 keys. 2015-12-18 23:34:13 +00:00
const.cc Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
digest.cc Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
generate_ed25519.cc Replace Scoped* heap types with bssl::UniquePtr. 2016-09-01 22:22:54 +00:00
genrsa.cc Replace Scoped* heap types with bssl::UniquePtr. 2016-09-01 22:22:54 +00:00
internal.h Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
pkcs12.cc Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
rand.cc Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
server.cc Don't return invalid versions in version_from_wire. 2016-09-21 19:51:45 +00:00
speed.cc Remove RC4 from TLS for real. 2016-09-16 03:06:36 +00:00
tool.cc Revert "Move C++ helpers into |bssl| namespace." 2016-07-12 08:09:33 -07:00
transport_common.cc Print out the signature algorithm in bssl client. 2016-09-09 21:42:30 +00:00
transport_common.h Teach bssl server about -max-version and -min-version. 2016-07-17 08:18:58 +00:00