boringssl/crypto/hmac/hmac.c
Eric Roman 2fe7f2d0d9 Initialize HMAC keys to zero.
In an attempt to assign a zero-length HMAC key, consumers might
incorrectly call:

   HMAC_Init_ex(key=NULL, key_len=0)

This does not work as expected since |key==NULL| has special semantics.
This bug may consequently result in uninitialized memory being used for
the HMAC key data.

This workaround doesn't fix all the problems associated with this
pattern, however by defaulting to a zero key the results are more
predictable than before.

BUG=http://crbug.com/449409

Change-Id: I777276d57c61f1c0cce80b18e28a9b063784733f
Reviewed-on: https://boringssl-review.googlesource.com/3040
Reviewed-by: Adam Langley <agl@google.com>
2015-01-28 01:27:25 +00:00

232 lines
7.9 KiB
C

/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
* All rights reserved.
*
* This package is an SSL implementation written
* by Eric Young (eay@cryptsoft.com).
* The implementation was written so as to conform with Netscapes SSL.
*
* This library is free for commercial and non-commercial use as long as
* the following conditions are aheared to. The following conditions
* apply to all code found in this distribution, be it the RC4, RSA,
* lhash, DES, etc., code; not just the SSL code. The SSL documentation
* included with this distribution is covered by the same copyright terms
* except that the holder is Tim Hudson (tjh@cryptsoft.com).
*
* Copyright remains Eric Young's, and as such any Copyright notices in
* the code are not to be removed.
* If this package is used in a product, Eric Young should be given attribution
* as the author of the parts of the library used.
* This can be in the form of a textual message at program startup or
* in documentation (online or textual) provided with the package.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. All advertising materials mentioning features or use of this software
* must display the following acknowledgement:
* "This product includes cryptographic software written by
* Eric Young (eay@cryptsoft.com)"
* The word 'cryptographic' can be left out if the rouines from the library
* being used are not cryptographic related :-).
* 4. If you include any Windows specific code (or a derivative thereof) from
* the apps directory (application code) you must include an acknowledgement:
* "This product includes software written by Tim Hudson (tjh@cryptsoft.com)"
*
* THIS SOFTWARE IS PROVIDED BY ERIC YOUNG ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* The licence and distribution terms for any publically available version or
* derivative of this code cannot be changed. i.e. this code cannot simply be
* copied and put under another distribution licence
* [including the GNU Public Licence.] */
#include <openssl/hmac.h>
#include <assert.h>
#include <openssl/mem.h>
uint8_t *HMAC(const EVP_MD *evp_md, const void *key, size_t key_len,
const uint8_t *data, size_t data_len, uint8_t *out,
unsigned int *out_len) {
HMAC_CTX ctx;
static uint8_t static_out_buffer[EVP_MAX_MD_SIZE];
/* OpenSSL has traditionally supported using a static buffer if |out| is
* NULL. We maintain that but don't document it. This behaviour should be
* considered to be deprecated. */
if (out == NULL) {
out = static_out_buffer;
}
/* If key_len is 0, the value of key doesn't matter. However, if we pass
* key == NULL into HMAC_Init, it interprets it to mean "use the previous
* value" instead of using a key of length 0. */
if (key == NULL && key_len == 0) {
key = static_out_buffer;
}
HMAC_CTX_init(&ctx);
if (!HMAC_Init(&ctx, key, key_len, evp_md) ||
!HMAC_Update(&ctx, data, data_len) ||
!HMAC_Final(&ctx, out, out_len)) {
out = NULL;
}
HMAC_CTX_cleanup(&ctx);
return out;
}
void HMAC_CTX_init(HMAC_CTX *ctx) {
ctx->md = NULL;
ctx->key_length = 0;
EVP_MD_CTX_init(&ctx->i_ctx);
EVP_MD_CTX_init(&ctx->o_ctx);
EVP_MD_CTX_init(&ctx->md_ctx);
}
void HMAC_CTX_cleanup(HMAC_CTX *ctx) {
EVP_MD_CTX_cleanup(&ctx->i_ctx);
EVP_MD_CTX_cleanup(&ctx->o_ctx);
EVP_MD_CTX_cleanup(&ctx->md_ctx);
OPENSSL_cleanse(ctx, sizeof(ctx));
}
int HMAC_Init_ex(HMAC_CTX *ctx, const void *key, size_t key_len,
const EVP_MD *md, ENGINE *impl) {
unsigned i, reset = 0;
uint8_t pad[HMAC_MAX_MD_CBLOCK];
if (md != NULL) {
if (ctx->md == NULL && key == NULL && ctx->key_length == 0) {
/* TODO(eroman): Change the API instead of this hack.
* If a key hasn't yet been assigned to the context, then default to using
* an all-zero key. This is to work around callers of
* HMAC_Init_ex(key=NULL, key_len=0) intending to set a zero-length key.
* Rather than resulting in uninitialized memory reads, it will
* predictably use a zero key. */
memset(ctx->key, 0, sizeof(ctx->key));
}
reset = 1;
ctx->md = md;
} else {
md = ctx->md;
}
if (key != NULL) {
size_t block_size = EVP_MD_block_size(md);
reset = 1;
assert(block_size <= sizeof(ctx->key));
if (block_size < key_len) {
if (!EVP_DigestInit_ex(&ctx->md_ctx, md, impl) ||
!EVP_DigestUpdate(&ctx->md_ctx, key, key_len) ||
!EVP_DigestFinal_ex(&(ctx->md_ctx), ctx->key, &ctx->key_length)) {
goto err;
}
} else {
assert(key_len >= 0 && key_len <= sizeof(ctx->key));
memcpy(ctx->key, key, key_len);
ctx->key_length = key_len;
}
if (ctx->key_length != HMAC_MAX_MD_CBLOCK) {
memset(&ctx->key[ctx->key_length], 0, sizeof(ctx->key) - ctx->key_length);
}
}
if (reset) {
for (i = 0; i < HMAC_MAX_MD_CBLOCK; i++) {
pad[i] = 0x36 ^ ctx->key[i];
}
if (!EVP_DigestInit_ex(&ctx->i_ctx, md, impl) ||
!EVP_DigestUpdate(&ctx->i_ctx, pad, EVP_MD_block_size(md))) {
goto err;
}
for (i = 0; i < HMAC_MAX_MD_CBLOCK; i++) {
pad[i] = 0x5c ^ ctx->key[i];
}
if (!EVP_DigestInit_ex(&ctx->o_ctx, md, impl) ||
!EVP_DigestUpdate(&ctx->o_ctx, pad, EVP_MD_block_size(md))) {
goto err;
}
}
if (!EVP_MD_CTX_copy_ex(&ctx->md_ctx, &ctx->i_ctx)) {
goto err;
}
return 1;
err:
return 0;
}
int HMAC_Update(HMAC_CTX *ctx, const uint8_t *data, size_t data_len) {
return EVP_DigestUpdate(&ctx->md_ctx, data, data_len);
}
int HMAC_Final(HMAC_CTX *ctx, uint8_t *out, unsigned int *out_len) {
unsigned int i;
uint8_t buf[EVP_MAX_MD_SIZE];
if (!EVP_DigestFinal_ex(&ctx->md_ctx, buf, &i) ||
!EVP_MD_CTX_copy_ex(&ctx->md_ctx, &ctx->o_ctx) ||
!EVP_DigestUpdate(&ctx->md_ctx, buf, i) ||
!EVP_DigestFinal_ex(&ctx->md_ctx, out, out_len)) {
*out_len = 0;
return 0;
}
return 1;
}
size_t HMAC_size(const HMAC_CTX *ctx) {
return EVP_MD_size(ctx->md);
}
int HMAC_CTX_copy_ex(HMAC_CTX *dest, const HMAC_CTX *src) {
if (!EVP_MD_CTX_copy_ex(&dest->i_ctx, &src->i_ctx) ||
!EVP_MD_CTX_copy_ex(&dest->o_ctx, &src->o_ctx) ||
!EVP_MD_CTX_copy_ex(&dest->md_ctx, &src->md_ctx)) {
return 0;
}
memcpy(dest->key, src->key, HMAC_MAX_MD_CBLOCK);
dest->key_length = src->key_length;
dest->md = src->md;
return 1;
}
void HMAC_CTX_set_flags(HMAC_CTX *ctx, unsigned long flags) {
EVP_MD_CTX_set_flags(&ctx->i_ctx, flags);
EVP_MD_CTX_set_flags(&ctx->o_ctx, flags);
EVP_MD_CTX_set_flags(&ctx->md_ctx, flags);
}
int HMAC_Init(HMAC_CTX *ctx, const void *key, int key_len, const EVP_MD *md) {
if (key && md) {
HMAC_CTX_init(ctx);
}
return HMAC_Init_ex(ctx, key, key_len, md, NULL);
}
int HMAC_CTX_copy(HMAC_CTX *dest, const HMAC_CTX *src) {
HMAC_CTX_init(dest);
return HMAC_CTX_copy_ex(dest, src);
}