3120950b1e
Like the write half, rather than allocating the maximum size needed and relying on the malloc implementation to pool this sanely, allocate the size the TLS record-layer code believes it needs. As currently arranged, this will cause us to alternate from a small allocation (for the record header) and then an allocation sized to the record itself. Windows is reportedly bad at pooling large allocations, so, *if the server sends us smaller records*, this will avoid hitting the problem cases. If the server sends us size 16k records, the maximum allowed by ther protocol, we simply must buffer up to that amount and will continue to allocate similar sizes as before (although slightly smaller; this CL also fixes small double-counting we did on the allocation sizes). Separately, we'll gather some metrics in Chromium to see what common record sizes are to determine if this optimization is sufficient. This is intended as an easy optimization we can do now, in advance of ongoing work to fix the extra layer of buffering between Chromium and BoringSSL with an in-place decrypt API. Bug: chromium:524258 Change-Id: I233df29df1212154c49fee4285ccc37be12f81dc Reviewed-on: https://boringssl-review.googlesource.com/17329 Reviewed-by: Adam Langley <agl@google.com> |
||
|---|---|---|
| .github | ||
| crypto | ||
| decrepit | ||
| fipstools | ||
| fuzz | ||
| include/openssl | ||
| infra/config | ||
| ssl | ||
| third_party | ||
| tool | ||
| util | ||
| .clang-format | ||
| .gitignore | ||
| API-CONVENTIONS.md | ||
| BUILDING.md | ||
| CMakeLists.txt | ||
| codereview.settings | ||
| CONTRIBUTING.md | ||
| FUZZING.md | ||
| INCORPORATING.md | ||
| LICENSE | ||
| PORTING.md | ||
| README.md | ||
| sources.cmake | ||
| STYLE.md | ||
BoringSSL
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful:
- PORTING.md: how to port OpenSSL-using code to BoringSSL.
- BUILDING.md: how to build BoringSSL
- INCORPORATING.md: how to incorporate BoringSSL into a project.
- API-CONVENTIONS.md: general API conventions for BoringSSL consumers and developers.
- STYLE.md: rules and guidelines for coding style.
- include/openssl: public headers with API documentation in comments. Also available online.
- FUZZING.md: information about fuzzing BoringSSL.
- CONTRIBUTING.md: how to contribute to BoringSSL.