kris/boringssl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
37646838e9
boringssl/ssl/test/runner
History
Adam Langley 37646838e9 Have |SSL_get_verify_result| return |X509_V_OK| when no client certificate is given. 
9498e74 changed the default value of verify_result to an error. This
tripped up NGINX, which depends on a bug[1] in OpenSSL. netty-tcnative
also uses this behavior, though it currently isn't tripped up by 9498e74
because it calls |SSL_set_verify_result|. However, we would like to
remove |SSL_set_verify_result| and with two data points, it seems this
is behavior we must preserve.

This change sets |verify_result| to |X509_V_OK| when a) no client
certificate is requested or b) none is given and it's optional.

[1] See BUGS in https://www.openssl.org/docs/manmaster/ssl/SSL_get_verify_result.html

Change-Id: Ibd33660ae409bfe272963a8c39b7e9aa83c3d635
Reviewed-on: https://boringssl-review.googlesource.com/9067
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
2016-08-18 20:37:10 +00:00
..
curve25519 Bundle a copy of golang.org/x/crypto/curve25519 for testing. 2015-12-22 17:47:53 +00:00
newhope Fix mixed comment markers. 2016-08-01 14:52:39 +00:00
poly1305 Switch the bundled poly1305 to relative imports. 2015-12-22 17:47:28 +00:00
alert.go Add support for TLS 1.3 PSK resumption in Go. 2016-08-02 19:37:07 +00:00
cert.pem Adding RSA-PSS signature algorithms. 2016-07-12 19:10:51 +00:00
chacha20_poly1305_test.go Fix mixed comment markers. 2016-08-01 14:52:39 +00:00
chacha20_poly1305.go Fix mixed comment markers. 2016-08-01 14:52:39 +00:00
channel_id_key.pem
cipher_suites.go Add support for TLS 1.3 PSK resumption in Go. 2016-08-02 19:37:07 +00:00
common.go Request contexts are now illegal during the handshake. 2016-08-18 15:40:40 +00:00
conn.go Add support for TLS 1.3 PSK resumption in Go. 2016-08-02 19:37:07 +00:00
deterministic.go Fix mixed comment markers. 2016-08-01 14:52:39 +00:00
dtls.go Check for buffered handshake messages on cipher change in DTLS. 2016-07-16 08:25:02 +00:00
ecdsa_p256_cert.pem Match ECDSA curve with hash in tests. 2016-07-12 18:26:14 +00:00
ecdsa_p256_key.pem Convert all of our test private keys to PKCS#8 PEM blobs. 2016-07-28 21:54:02 +00:00
ecdsa_p384_cert.pem Match ECDSA curve with hash in tests. 2016-07-12 18:26:14 +00:00
ecdsa_p384_key.pem Convert all of our test private keys to PKCS#8 PEM blobs. 2016-07-28 21:54:02 +00:00
ecdsa_p521_cert.pem Match ECDSA curve with hash in tests. 2016-07-12 18:26:14 +00:00
ecdsa_p521_key.pem Convert all of our test private keys to PKCS#8 PEM blobs. 2016-07-28 21:54:02 +00:00
handshake_client.go Request contexts are now illegal during the handshake. 2016-08-18 15:40:40 +00:00
handshake_messages.go Add support for TLS 1.3 PSK resumption in Go. 2016-08-02 19:37:07 +00:00
handshake_server.go Request contexts are now illegal during the handshake. 2016-08-18 15:40:40 +00:00
hkdf_test.go Fix mixed comment markers. 2016-08-01 14:52:39 +00:00
hkdf.go Fix mixed comment markers. 2016-08-01 14:52:39 +00:00
key_agreement.go Adding HelloRetryRequest. 2016-07-20 16:56:41 +00:00
key.pem Convert all of our test private keys to PKCS#8 PEM blobs. 2016-07-28 21:54:02 +00:00
packet_adapter.go Add tests for bad ChangeCipherSpecs. 2015-12-16 17:39:43 +00:00
prf.go Add support for TLS 1.3 PSK resumption in Go. 2016-08-02 19:37:07 +00:00
recordingconn.go Fix mixed comment markers. 2016-08-01 14:52:39 +00:00
rsa_1024_cert.pem Account for key size when selecting RSA-PSS. 2016-07-13 15:32:05 +00:00
rsa_1024_key.pem Convert rsa_1024_key.pem to a PKCS#8 PEM blob. 2016-08-01 18:42:17 +00:00
runner_test.go Fix mixed comment markers. 2016-08-01 14:52:39 +00:00
runner.go Have |SSL_get_verify_result| return |X509_V_OK| when no client certificate is given. 2016-08-18 20:37:10 +00:00
sign.go Generalize invalid signature tests and run at all versions. 2016-07-14 16:07:56 +00:00
test_output.go Support unimplemented tests in test runner. 2016-07-27 18:54:40 +00:00
ticket.go Add support for TLS 1.3 PSK resumption in Go. 2016-08-02 19:37:07 +00:00
tls.go Make the runner tests a go “test” 2015-09-30 17:10:45 +00:00