3c37d0aba5
Rather than printing the SSL_ERROR_* constants, print the actual error. This should be a bit more understandable. Debugging this also uncovered some other issues on Windows: - We were mixing up C runtime and Winsock errors, which are separate in Windows. - The thread local implementation interferes with WSAGetLastError due to a quirk of TlsGetValue. This could affect other Windows consumers. (Chromium uses a custom BIO, so it isn't affected.) - SocketSetNonBlocking also interferes with WSAGetLastError. - Listen for FD_CLOSE along with FD_READ. Connection close does not signal FD_READ. (The select loop only barely works on Windows anyway due to issues with stdin and line buffering, but if we take stdin out of the equation, FD_CLOSE can be tested.) Change-Id: Ia8d42b5ac39ebb3045d410dd768f83a3bb88b2cb Reviewed-on: https://boringssl-review.googlesource.com/28186 Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: Steven Valdez <svaldez@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> |
||
---|---|---|
.. | ||
args.cc | ||
ciphers.cc | ||
client.cc | ||
CMakeLists.txt | ||
const.cc | ||
digest.cc | ||
file.cc | ||
generate_ed25519.cc | ||
genrsa.cc | ||
internal.h | ||
pkcs12.cc | ||
rand.cc | ||
server.cc | ||
sign.cc | ||
speed.cc | ||
tool.cc | ||
transport_common.cc | ||
transport_common.h |